Fix SliverAppBar title opacity and test all cases #26021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
| // 1 | 0 | 0 || 1.0 | ||
| // 1 | 0 | 1 || 1.0 | ||
| // 1 | 1 | 0 || 1.0 | ||
| // 1 | 1 | 1 || fade |
This comment has been minimized.
This comment has been minimized.
zoechi
added
framework
HansMuller
approved these changes
Jan 5, 2019
| final double toolbarOpacity = pinned ? 1.0 | ||
| : ((visibleMainHeight - _bottomHeight) / kToolbarHeight).clamp(0.0, 1.0); | ||
|
|
||
| // Truth table for `toolbarOpacity`: |
Contributor
There was a problem hiding this comment.
It looks like the result is fade when pinned=false and 1.0 when pinned=true except with one exception (the last row). Aha: I see that the implementation boils it down nicely:
!pinned || (floating && bottom != null)
JediBurrell
pushed a commit
to JediBurrell/flutter
that referenced
this pull request
Jan 8, 2019
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25993.
Follow-up to #25051.