Skip to content

[camera_android_camerax] Modify plugin to assume mp4 format for captured videos #10273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Oct 23, 2025
Merged

[camera_android_camerax] Modify plugin to assume mp4 format for captured videos #10273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d745c39
change temp extension to mp4
camsim99 Oct 21, 2025
6ee57e1
Merge remote-tracking branch 'upstream/main' into camx_mp4
camsim99 Oct 22, 2025
27b75f0
Merge branch 'main' into camx_mp4
camsim99 Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/camera/camera_android_camerax/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.6.24

* Change plugin to assume mp4 format for capture videos.

## 0.6.23+5

* Fixes `IllegalArgumentException` that could occur during image streaming when using NV21.
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1181,7 +1181,7 @@ class AndroidCameraCameraX extends CameraPlatform {

videoOutputPath = await systemServicesManager.getTempFilePath(
videoPrefix,
'.temp',
'.mp4',
);
pendingRecording = await recorder!.prepareRecording(videoOutputPath!);

Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: camera_android_camerax
description: Android implementation of the camera plugin using the CameraX library.
repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.6.23+5
version: 0.6.24

environment:
sdk: ^3.9.0
Expand Down
46 changes: 23 additions & 23 deletions packages/camera/camera_android_camerax/test/android_camera_camerax_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3311,7 +3311,7 @@ void main() {
camera.captureOrientationLocked = true;

// Tell plugin to create detached Observer when camera info updated.
const String outputPath = '/temp/REC123.temp';
const String outputPath = '/temp/REC123.mp4';
camera.proxy = CameraXProxy(
newObserver:
<T>({
Expand Down Expand Up @@ -3350,7 +3350,7 @@ void main() {
when(
mockSystemServicesManager.getTempFilePath(
camera.videoPrefix,
'.temp',
'.mp4',
),
).thenAnswer((_) async => outputPath);
return mockSystemServicesManager;
Expand Down Expand Up @@ -3480,7 +3480,7 @@ void main() {
camera.captureOrientationLocked = true;

// Tell plugin to create detached Observer when camera info updated.
const String outputPath = '/temp/REC123.temp';
const String outputPath = '/temp/REC123.mp4';
camera.proxy = CameraXProxy(
newObserver:
<T>({
Expand Down Expand Up @@ -3519,7 +3519,7 @@ void main() {
when(
mockSystemServicesManager.getTempFilePath(
camera.videoPrefix,
'.temp',
'.mp4',
),
).thenAnswer((_) async => outputPath);
return mockSystemServicesManager;
Expand Down Expand Up @@ -3607,7 +3607,7 @@ void main() {
verify(
camera.systemServicesManager.getTempFilePath(
camera.videoPrefix,
'.temp',
'.mp4',
),
).called(1);
verifyNoMoreInteractions(camera.systemServicesManager);
Expand Down Expand Up @@ -3650,7 +3650,7 @@ void main() {
camera.captureOrientationLocked = true;

// Tell plugin to create detached Analyzer for testing.
const String outputPath = '/temp/REC123.temp';
const String outputPath = '/temp/REC123.mp4';
camera.proxy = CameraXProxy(
newObserver:
<T>({
Expand Down Expand Up @@ -3689,7 +3689,7 @@ void main() {
when(
mockSystemServicesManager.getTempFilePath(
camera.videoPrefix,
'.temp',
'.mp4',
),
).thenAnswer((_) async => outputPath);
return mockSystemServicesManager;
Expand Down Expand Up @@ -3807,7 +3807,7 @@ void main() {
camera.enableRecordingAudio = false;

// Tell plugin to mock call to get current video orientation and mock Camera2CameraInfo retrieval.
const String outputPath = '/temp/REC123.temp';
const String outputPath = '/temp/REC123.mp4';
camera.proxy = CameraXProxy(
newObserver:
<T>({
Expand Down Expand Up @@ -3848,7 +3848,7 @@ void main() {
when(
mockSystemServicesManager.getTempFilePath(
camera.videoPrefix,
'.temp',
'.mp4',
),
).thenAnswer((_) async => outputPath);
return mockSystemServicesManager;
Expand Down Expand Up @@ -4354,7 +4354,7 @@ void main() {
when(
mockSystemServicesManager.getTempFilePath(
camera.videoPrefix,
'.temp',
'.mp4',
),
).thenAnswer((_) async => outputPath);
return mockSystemServicesManager;
Expand Down Expand Up @@ -4696,7 +4696,7 @@ void main() {
when(
mockSystemServicesManager.getTempFilePath(
camera.videoPrefix,
'.temp',
'.mp4',
),
).thenAnswer((_) async => outputPath);
return mockSystemServicesManager;
Expand Down Expand Up @@ -7600,7 +7600,7 @@ void main() {
camera.captureOrientationLocked = true;

// Tell plugin to create detached Observer when camera info updated.
const String outputPath = '/temp/REC123.temp';
const String outputPath = '/temp/REC123.mp4';
camera.proxy = CameraXProxy(
newObserver:
<T>({
Expand Down Expand Up @@ -7639,7 +7639,7 @@ void main() {
when(
mockSystemServicesManager.getTempFilePath(
camera.videoPrefix,
'.temp',
'.mp4',
),
).thenAnswer((_) async => outputPath);
return mockSystemServicesManager;
Expand Down Expand Up @@ -7744,7 +7744,7 @@ void main() {
camera.captureOrientationLocked = true;

// Tell plugin to create detached Observer when camera info updated.
const String outputPath = '/temp/REC123.temp';
const String outputPath = '/temp/REC123.mp4';
camera.proxy = CameraXProxy(
newObserver:
<T>({
Expand Down Expand Up @@ -7783,7 +7783,7 @@ void main() {
when(
mockSystemServicesManager.getTempFilePath(
camera.videoPrefix,
'.temp',
'.mp4',
),
).thenAnswer((_) async => outputPath);
return mockSystemServicesManager;
Expand Down Expand Up @@ -7888,7 +7888,7 @@ void main() {
camera.captureOrientationLocked = true;

// Tell plugin to create detached Observer when camera info updated.
const String outputPath = '/temp/REC123.temp';
const String outputPath = '/temp/REC123.mp4';
camera.proxy = CameraXProxy(
newObserver:
<T>({
Expand Down Expand Up @@ -7927,7 +7927,7 @@ void main() {
when(
mockSystemServicesManager.getTempFilePath(
camera.videoPrefix,
'.temp',
'.mp4',
),
).thenAnswer((_) async => outputPath);
return mockSystemServicesManager;
Expand Down Expand Up @@ -8037,7 +8037,7 @@ void main() {
camera.captureOrientationLocked = true;

// Tell plugin to create detached Observer when camera info updated.
const String outputPath = '/temp/REC123.temp';
const String outputPath = '/temp/REC123.mp4';
camera.proxy = CameraXProxy(
newAnalyzer:
({
Expand Down Expand Up @@ -8091,7 +8091,7 @@ void main() {
when(
mockSystemServicesManager.getTempFilePath(
camera.videoPrefix,
'.temp',
'.mp4',
),
).thenAnswer((_) async => outputPath);
return mockSystemServicesManager;
Expand Down Expand Up @@ -8205,7 +8205,7 @@ void main() {
camera.captureOrientationLocked = true;

// Tell plugin to create detached Observer when camera info updated.
const String outputPath = '/temp/REC123.temp';
const String outputPath = '/temp/REC123.mp4';
camera.proxy = CameraXProxy(
newAnalyzer:
({
Expand Down Expand Up @@ -8259,7 +8259,7 @@ void main() {
when(
mockSystemServicesManager.getTempFilePath(
camera.videoPrefix,
'.temp',
'.mp4',
),
).thenAnswer((_) async => outputPath);
return mockSystemServicesManager;
Expand Down Expand Up @@ -8365,7 +8365,7 @@ void main() {
camera.captureOrientationLocked = true;

// Tell plugin to create detached Observer when camera info updated.
const String outputPath = '/temp/REC123.temp';
const String outputPath = '/temp/REC123.mp4';
camera.proxy = CameraXProxy(
newAnalyzer:
({
Expand Down Expand Up @@ -8419,7 +8419,7 @@ void main() {
when(
mockSystemServicesManager.getTempFilePath(
camera.videoPrefix,
'.temp',
'.mp4',
),
).thenAnswer((_) async => outputPath);
return mockSystemServicesManager;
Expand Down