Skip to content

re-add the null safety checks #10524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jesswrd wants to merge 3 commits into from
Closed

re-add the null safety checks #10524

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
999543b
re-add the null safety checks
jesswrd Nov 26, 2025
2cdae27
assigning the nullable field to local variable may fix things
jesswrd Nov 26, 2025
238448e
format
jesswrd Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions script/tool/lib/src/update_dependency_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class UpdateDependencyCommand extends PackageLoopingCommand {
final String? version = getNullableStringArg(_versionFlag);
if (version == null) {
final PubVersionFinderResponse response = await _pubVersionFinder
.getPackageVersion(packageName: _targetPubPackage);
.getPackageVersion(packageName: _targetPubPackage!);
switch (response.result) {
case PubVersionFinderResult.success:
_targetVersion = response.versions.first.toString();
Expand Down Expand Up @@ -204,7 +204,7 @@ A version with a valid format (3 numbers separated by 2 periods) must be provide
@override
Future<PackageResult> runForPackage(RepositoryPackage package) async {
if (_targetPubPackage != null) {
return _runForPubDependency(package, _targetPubPackage);
return _runForPubDependency(package, _targetPubPackage!);
Copy link

@gemini-code-assist gemini-code-assist bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While using ! is valid here because of the null check on the previous line, a more idiomatic and safer approach in Dart is to assign the nullable field to a local variable. This allows Dart's flow analysis to promote the variable to a non-nullable type within an if block, avoiding the need for a null assertion.

Consider refactoring this block to:

    final String? targetPubPackage = _targetPubPackage;
    if (targetPubPackage != null) {
      return _runForPubDependency(package, targetPubPackage);
    }

}
if (_targetAndroidDependency != null) {
return _runForAndroidDependency(package);
Expand Down