Skip to content

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Dec 4, 2025

Part of flutter/flutter#172933

We're standing up a new instance of Gold for flutter/packages to be able to execute golden file tests (for future material and cupertino packages).
The frontend is not up yet, but this new instance will be using a different backend than the flutter/flutter instance, so I am poking and testing here to validate a few things

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a goldctl dependency to the web_dart_unit_tests_wasm CI target, likely for testing a new Gold backend. The change is straightforward. My review includes one suggestion to improve the maintainability of the YAML configuration by using native YAML structures instead of an embedded JSON string.

Comment on lines 273 to 276
dependencies: >-
[
{"dependency": "goldctl", "version": "git_revision:2387d6fff449587eecbb7e45b2692ca0710b63b9"},
]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved readability and maintainability, consider using native YAML syntax for the dependency list instead of embedding a JSON string. This makes the configuration easier to read and modify, especially if more dependencies are added in the future. Most modern CI systems can correctly parse structured YAML properties.

      dependencies:
        - dependency: goldctl
          version: git_revision:2387d6fff449587eecbb7e45b2692ca0710b63b9

@github-actions github-actions bot added p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package triage-framework Should be looked at in framework triage labels Dec 4, 2025
@Piinks
Copy link
Contributor Author

Piinks commented Dec 5, 2025

Closing, got what I needed to develop further.

@Piinks Piinks closed this Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant