Skip to content

[go_router] Refactor internal classes and methods #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnpryan merged 38 commits into from
Jul 22, 2022
Merged

[go_router] Refactor internal classes and methods #2317

Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
370a279
Refactor internal classes and methods
johnpryan Jul 1, 2022
aaec44a
format
johnpryan Jul 12, 2022
61fbc2d
Sort imports
johnpryan Jul 12, 2022
632b012
Update changelog
johnpryan Jul 12, 2022
40e2c61
Address code review comments
johnpryan Jul 13, 2022
61da05d
remove routing library
johnpryan Jul 14, 2022
1c2577c
Move classes in go_router.dart into separate libraries
johnpryan Jul 14, 2022
db91f56
Move Configuration.validate() into constructor
johnpryan Jul 14, 2022
1eaf6c3
Remove comment
johnpryan Jul 14, 2022
ea01665
use continue in redirect loop
johnpryan Jul 14, 2022
d4c2ff9
Fix comments
johnpryan Jul 14, 2022
199c353
Sort imports
johnpryan Jul 14, 2022
b8a65af
Fix logging in configuration
johnpryan Jul 14, 2022
85fe41d
add visibleForTesting annotation
johnpryan Jul 14, 2022
ccb8097
Merge branch 'main' into refactor
johnpryan Jul 14, 2022
e0bb4f4
Updates from merge with main
johnpryan Jul 14, 2022
4c17bba
Format
johnpryan Jul 15, 2022
8449014
Add TODOs to make Router implementation classes private
johnpryan Jul 15, 2022
9b40f1e
Add copyright headers
johnpryan Jul 15, 2022
0e14a04
Fix tests
johnpryan Jul 15, 2022
73feaa8
Merge branch 'main' into refactor
johnpryan Jul 20, 2022
e3458e6
format
johnpryan Jul 20, 2022
13bc273
fix comment
johnpryan Jul 20, 2022
2a350ad
Update packages/go_router/lib/src/parser.dart
johnpryan Jul 21, 2022
fc82dbb
add whitespace
johnpryan Jul 21, 2022
86c8961
format
johnpryan Jul 21, 2022
7f8954c
Hide typedefs that weren't previously exported
johnpryan Jul 21, 2022
fdcf0ed
Delete empty file
johnpryan Jul 21, 2022
78e60a6
add missing import
johnpryan Jul 21, 2022
26b4c12
Specify version 4.1.2 in pubspec.yaml
johnpryan Jul 21, 2022
0c5436e
Update packages/go_router/lib/src/builder.dart
johnpryan Jul 21, 2022
348697b
Fix comment
johnpryan Jul 21, 2022
77f2244
Add isError and error getters to RouteMatchList
johnpryan Jul 21, 2022
820162d
Add issue links to TODO comments
johnpryan Jul 21, 2022
07f7ada
Add link to issue for TODO
johnpryan Jul 22, 2022
686d315
Merge branch 'main' into refactor
johnpryan Jul 22, 2022
5e282d3
Re-apply code from #2306 due to merge conflicts
johnpryan Jul 22, 2022
714e682
Add issue references
johnpryan Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@johnpryan
johnpryan committed Jul 15, 2022
commit 0e14a04d05092a13534d8960ce5d11ec11fe33fa
5 changes: 2 additions & 3 deletions packages/go_router/test/test_helpers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import 'package:flutter/src/foundation/diagnostics.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:go_router/go_router.dart';
import 'package:go_router/src/match.dart';
import 'package:go_router/src/misc/error_screen.dart';

Future<GoRouter> createGoRouter(
WidgetTester tester, {
Expand All @@ -23,7 +22,7 @@ Future<GoRouter> createGoRouter(
GoRoute(path: '/', builder: (_, __) => const DummyStatefulWidget()),
GoRoute(
path: '/error',
builder: (_, __) => const ErrorScreen(null),
builder: (_, __) => TestErrorScreen(TestFailure('Exception')),
),
],
navigatorBuilder: navigatorBuilder,
Expand Down Expand Up @@ -172,7 +171,7 @@ Future<GoRouter> createRouter(
initialLocation: initialLocation,
redirectLimit: redirectLimit,
errorBuilder: (BuildContext context, GoRouterState state) =>
ErrorScreen(state.error!),
TestErrorScreen(state.error!),
debugLogDiagnostics: false,
);
await tester.pumpWidget(
Expand Down