Skip to content

[go_router] Allow any number of the same page on the stack #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
Aug 1, 2022
Merged

[go_router] Allow any number of the same page on the stack #2339

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e581489
[go_router] Allow any number of the same page on the stack
koji-1009 Jul 20, 2022
f276569
[go_router] Update pubspec and CHANGELOG
koji-1009 Jul 20, 2022
12388eb
[go_router] Add test
koji-1009 Jul 20, 2022
feb193d
Apply suggestions from code review
koji-1009 Jul 25, 2022
2ee5fd6
[go_router] Add await tester.pumpAndSettle() to verify
koji-1009 Jul 26, 2022
29a9e8c
Merge branch 'main' into fix_page_twice_push
koji-1009 Jul 30, 2022
4496b4f
[go_router] Fix conflicts
koji-1009 Jul 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[go_router] Add await tester.pumpAndSettle() to verify
  • Loading branch information
@koji-1009
koji-1009 committed Jul 26, 2022
commit 2ee5fd6b94869021ad5702b15736ada948e3d1b7
4 changes: 4 additions & 0 deletions packages/go_router/test/delegate_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,17 @@ void main() {
);

goRouter.push('/a');
Copy link
Contributor

@chunhtai chunhtai Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do an await tester.pumpAndSettle() in between every push to verify it does not crash?

Copy link
Contributor Author

@koji-1009 koji-1009 Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, I fixed it in 2ee5fd6.

await tester.pumpAndSettle();

expect(goRouter.routerDelegate.matches.matches.length, 2);
expect(
goRouter.routerDelegate.matches.matches[1].pageKey,
const Key('/a-p1'),
);

goRouter.push('/a');
await tester.pumpAndSettle();

expect(goRouter.routerDelegate.matches.matches.length, 3);
expect(
goRouter.routerDelegate.matches.matches[2].pageKey,
Expand Down