Skip to content

Change typed_routing.dart back to route_data.dart #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnpryan merged 6 commits into from
Jul 26, 2022
Merged

Change typed_routing.dart back to route_data.dart #2385

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
302668a
Change typed_routing.dart back to route_data.dart
johnpryan Jul 26, 2022
981799c
sort imports
johnpryan Jul 26, 2022
14e1274
Use flutter_plugin_tools 0.8.9
johnpryan Jul 26, 2022
3bda58c
Bump go_router version to 4.2.2
johnpryan Jul 26, 2022
3be46fb
Update CHANGELOG
johnpryan Jul 26, 2022
ee07a82
Update CHANGELOG.md
johnpryan Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/scripts/prepare_tool.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ git fetch origin main

# Pinned version of the plugin tools, to avoid breakage in this repository
# when pushing updates from flutter/plugins.
dart pub global activate flutter_plugin_tools 0.8.7
dart pub global activate flutter_plugin_tools 0.8.9
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
with:
fetch-depth: 0 # Fetch all history so the tool can get all the tags to determine version.
- name: Set up tools
run: dart pub global activate flutter_plugin_tools 0.8.7
run: dart pub global activate flutter_plugin_tools 0.8.9

# # This workflow should be the last to run. So wait for all the other tests to succeed.
- name: Wait on all tests
Expand Down
4 changes: 4 additions & 0 deletions packages/go_router/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 4.2.2

- Fixes a bug where go_router_builder wasn't detecting annotations
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Missing period (per style guide).


## 4.2.1

- Refactors internal classes and methods
Expand Down
2 changes: 1 addition & 1 deletion packages/go_router/lib/go_router.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ export 'src/misc/inherited_router.dart';
export 'src/misc/refresh_stream.dart';
export 'src/pages/custom_transition_page.dart';
export 'src/platform.dart' show UrlPathStrategy;
export 'src/route_data.dart' show GoRouteData, TypedGoRoute;
export 'src/router.dart';
export 'src/typed_routing.dart' show GoRouteData, TypedGoRoute;
export 'src/typedefs.dart' show GoRouterPageBuilder, GoRouterRedirect;
2 changes: 1 addition & 1 deletion packages/go_router/lib/src/builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import 'misc/error_screen.dart';
import 'pages/cupertino.dart';
import 'pages/custom_transition_page.dart';
import 'pages/material.dart';
import 'typed_routing.dart';
import 'route_data.dart';
import 'typedefs.dart';

/// Builds the top-level Navigator for GoRouter.
Expand Down
0 ...ages/go_router/lib/src/typed_routing.dart → packages/go_router/lib/src/route_data.dart
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/go_router/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: go_router
description: A declarative router for Flutter based on Navigation 2 supporting
deep linking, data-driven routes and more
version: 4.2.1
version: 4.2.2
repository: https://github.com/flutter/packages/tree/main/packages/go_router
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22

Expand Down