Skip to content

[pigeon] Null safe requires Dart 2.12 #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blasten merged 23 commits into from
Feb 2, 2021
Merged

[pigeon] Null safe requires Dart 2.12 #252

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
1c3e659
[pigeon] Null safe requires Dart 2.12
Dec 1, 2020
6912e2e
Update pigeon version
Dec 1, 2020
26ced6e
Merge branch 'master' into null_safe_pigeon
Dec 11, 2020
7d99ef5
Bump version in pubspec.yaml
Dec 11, 2020
099f7e9
Generator
Dec 11, 2020
0cefb0e
tense
Dec 11, 2020
34ad352
Version
Dec 11, 2020
f5416cf
Use Flutter master
Dec 11, 2020
9feb91a
Update setup script
Dec 11, 2020
2ae3b9f
Precache artifacts
Dec 12, 2020
0126fa0
debug
Dec 15, 2020
235d3c9
Try with different image
Dec 15, 2020
4108f07
Debug version of dartanalyzer
Dec 15, 2020
865b569
Upgrade Flutter version
Dec 15, 2020
01ada7d
Add ios-armv7_arm64
Jan 30, 2021
abbdcea
Merge branch 'master' into null_safe_pigeon
Jan 30, 2021
b0f0b41
Update podfile
Feb 1, 2021
d3b1794
Revert osx image
Feb 1, 2021
cc06ff1
Remove debug commands
Feb 1, 2021
de8e9ea
Remove xcpretty
Feb 2, 2021
228749a
Test on master and stable
Feb 2, 2021
318e04c
Skip test and add TODO
Feb 2, 2021
fcb0ca0
Clean up
Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pigeon/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.1.18

* Null safe required Dart 2.12.

## 0.1.17

* Split out test code generation for Dart into a separate file via the
Expand Down
4 changes: 2 additions & 2 deletions packages/pigeon/lib/dart_generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import 'generator_tools.dart';

/// Options that control how Dart code will be generated.
class DartOptions {
/// Determines if the generated code has null safety annotations (Dart >2.10 required).
/// Determines if the generated code has null safety annotations (Dart >=2.12 required).
bool isNullSafe = false;
}

Expand Down Expand Up @@ -194,7 +194,7 @@ void generateDart(DartOptions opt, Root root, StringSink sink) {
indent.writeln(
'// ignore_for_file: public_member_api_docs, non_constant_identifier_names, avoid_as, unused_import',
);
indent.writeln('// @dart = ${opt.isNullSafe ? '2.10' : '2.8'}');
indent.writeln('// @dart = ${opt.isNullSafe ? '2.12' : '2.8'}');
indent.writeln('import \'dart:async\';');
indent.writeln(
'import \'dart:typed_data\' show Uint8List, Int32List, Int64List, Float64List;',
Expand Down