Skip to content

[flutter_adaptive_scaffold] Change selectedIndex on standardNavigationRail to allow null value. #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 12 commits into from
Jan 25, 2023
Merged

[flutter_adaptive_scaffold] Change selectedIndex on standardNavigationRail to allow null value. #3088

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ef38758
changed selectedIndex on standardNavigationRail to allow null value
joshryandavis Jan 25, 2023
8900332
Update CHANGELOG.md
joshryandavis Jan 25, 2023
22c8bd7
increase version number
joshryandavis Jan 25, 2023
e1d71f7
Update CHANGELOG.md
joshryandavis Jan 25, 2023
31c3485
Update CHANGELOG.md
joshryandavis Jan 25, 2023
03a1751
change index types from int to int?
joshryandavis Jan 25, 2023
df4a67f
add test for slectedIndex can be set to null
joshryandavis Jan 25, 2023
b61e228
Update CHANGELOG.md
joshryandavis Jan 25, 2023
ca1d495
index types set to int? and ensure BottomNavigationRail currentIndex …
joshryandavis Jan 25, 2023
de99a64
Update packages/flutter_adaptive_scaffold/CHANGELOG.md
joshryandavis Jan 25, 2023
093011e
Update packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart
joshryandavis Jan 25, 2023
ccb6745
Update packages/flutter_adaptive_scaffold/CHANGELOG.md
joshryandavis Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test for slectedIndex can be set to null
  • Loading branch information
@joshryandavis
joshryandavis committed Jan 25, 2023
commit df4a67fdecea891beb480b50369d5a34ddad3d8a
17 changes: 17 additions & 0 deletions packages/flutter_adaptive_scaffold/test/adaptive_scaffold_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import 'package:flutter/material.dart';
import 'package:flutter_adaptive_scaffold/src/adaptive_scaffold.dart';
import 'package:flutter_test/flutter_test.dart';

import 'simulated_layout.dart';
import 'test_breakpoints.dart';

Expand Down Expand Up @@ -222,6 +223,22 @@ void main() {
});
},
);

/// Verify that selectedIndex of [AdaptiveScaffold.standardNavigationRail]
/// and [AdaptiveScaffold] can be set to null
testWidgets(
'adaptive scaffold selectedIndex can be set to null',
(WidgetTester tester) async {
await Future.forEach(SimulatedLayout.values,
(SimulatedLayout region) async {
int? selectedIndex;
final MaterialApp app = region.app(initialIndex: selectedIndex);
await tester.binding.setSurfaceSize(region.size);
await tester.pumpWidget(app);
await tester.pumpAndSettle();
});
},
);
}

/// An empty widget that implements [PreferredSizeWidget] to ensure that
Expand Down