Skip to content

Conversation

@tarrinneal
Copy link
Contributor

@tarrinneal tarrinneal commented Feb 6, 2023

Temporary linter ignore fix to allow greening of tree.
Should fix flutter roll #3173.

@goderbauer this is part of a todo that mentions your name. I don't think there's anything to be done atm though.

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@tarrinneal tarrinneal changed the title [flutter_adaptive_scaffold] fix for new analyzer rules to green tree Manual flutter roll and analyzer fix Feb 6, 2023
@tarrinneal tarrinneal added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Feb 6, 2023
@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2023
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments are resolved.

@tarrinneal tarrinneal removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2023
@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 6, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 6, 2023

auto label is removed for flutter/packages, pr: 3174, due to - The status or check suite readme_excerpts has failed. Please fix the issues identified (or deflake) before re-applying this label.

@tarrinneal tarrinneal added the override: no versioning needed Override the check requiring version bumps for most changes label Feb 6, 2023
@tarrinneal tarrinneal merged commit fa4775e into flutter:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: flutter_adaptive_scaffold

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants