Skip to content

[pigeon] Eliminate some of the test pigeons #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 10 commits into from
Feb 16, 2023
Merged

[pigeon] Eliminate some of the test pigeons #3213

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f8c5465
Fold in async_handlers.dart
stuartmorgan-g Feb 15, 2023
c002bb2
Remove some largely unused files
stuartmorgan-g Feb 16, 2023
a0a1e2f
Fold in the relevant parts of list.dart
stuartmorgan-g Feb 16, 2023
769e7e2
Remove java_double_host_api
stuartmorgan-g Feb 16, 2023
e177d58
Remove unnecessary double-generation of messages.dart
stuartmorgan-g Feb 16, 2023
314138c
Remove enum_args
stuartmorgan-g Feb 16, 2023
87efaa4
Remove some unnecesasry/duplicate unit tests
stuartmorgan-g Feb 16, 2023
8a19d8e
Eliminate android_unittest
stuartmorgan-g Feb 16, 2023
b972da0
Format
stuartmorgan-g Feb 16, 2023
c42e7d8
Remove build references on Windows
stuartmorgan-g Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove java_double_host_api
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Feb 16, 2023
commit 769e7e22546ff21d5ff57b1b1c0dcd79339e6650
4 changes: 4 additions & 0 deletions packages/pigeon/pigeons/core_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,10 @@ abstract class FlutterIntegrationCoreApi {
}

/// An API that can be implemented for minimal, compile-only tests.
//
// This is also here to test that multiple host APIs can be generated
// successfully in all languages (e.g., in Java where it requires having a
// wrapper class).
@HostApi()
abstract class HostTrivialApi {
void noop();
Expand Down
21 changes: 0 additions & 21 deletions packages/pigeon/pigeons/java_double_host_api.dart
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/pigeon/tool/shared/generation.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ Future<int> generatePigeons({required String baseDir}) async {
'core_tests',
'enum_args',
'enum',
'java_double_host_api',
'message',
'multiple_arity',
'non_null_fields',
Expand Down