Skip to content

[pigeon] Validate generated files in CI #3224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
Feb 17, 2023
Merged

[pigeon] Validate generated files in CI #3224

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
47f6b38
Add autoformatting option to generation
stuartmorgan-g Feb 17, 2023
d46e5c1
Extract to helper
stuartmorgan-g Feb 17, 2023
c06f3a3
Add validation
stuartmorgan-g Feb 17, 2023
7c47d56
Test change to demonstrate behavior
stuartmorgan-g Feb 17, 2023
ca1acb8
Actually fail when validation fails
stuartmorgan-g Feb 17, 2023
8b84c2b
Revert "Test change to demonstrate behavior"
stuartmorgan-g Feb 17, 2023
97910c7
Merge branch 'flutter:main' into pigeon-generation-validation
stuartmorgan Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Test change to demonstrate behavior" 
This reverts commit 7c47d56.
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Feb 17, 2023
commit 8b84c2b767361e1ba2eee6801baca157073fbe8a
2 changes: 1 addition & 1 deletion packages/pigeon/lib/cpp_generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ class CppHeaderGenerator extends StructuredGenerator<CppOptions> {
_writeCodec(generatorOptions, root, indent, api);
}
const List<String> generatedMessages = <String>[
' Generated interface from Pigeon that represents a handler of messages from Flutter. Test change.'
' Generated interface from Pigeon that represents a handler of messages from Flutter.'
];
addDocumentationComments(indent, api.documentationComments, _docCommentSpec,
generatorComments: generatedMessages);
Expand Down