Skip to content

[go_router_builder] Add ShellRoute support to go_router_builder #3269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnpryan wants to merge 10 commits into from
Closed

[go_router_builder] Add ShellRoute support to go_router_builder #3269

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3009606
Add ShellRoute support to go_router_builder
johnpryan Feb 22, 2023
87decf8
Merge branch 'main' into feature/shell-route-go-router-builder
johnpryan Feb 23, 2023
05599c6
Fix analysis issues
johnpryan Feb 23, 2023
01226ac
Fix go_router_builder test
johnpryan Feb 23, 2023
3028269
format
johnpryan Feb 23, 2023
801570a
Merge branch 'main' into feature/shell-route-go-router-builder
johnpryan Feb 23, 2023
6a76ebe
Increment minor version
johnpryan Feb 23, 2023
6a93b61
ignore deprected member use so downgraded_analyze step passes
johnpryan Feb 23, 2023
857225b
Revert old TODO
johnpryan Feb 23, 2023
84187da
Skip extensions for ShellRoute
johnpryan Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert old TODO
  • Loading branch information
@johnpryan
johnpryan committed Feb 23, 2023
commit 857225bb1094b6de546bf3a39b1169f8c00ce8fa
3 changes: 1 addition & 2 deletions packages/go_router_builder/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,7 @@ class PersonScreen extends StatelessWidget {
in person.details.entries)
ListTile(
title: Text(
// TODO(kevmoo): replace `split` with `name` when min SDK is 2.15
'${entry.key.toString().split('.').last} - ${entry.value}',
'${entry.key.name} - ${entry.value}',
),
trailing: OutlinedButton(
onPressed: () => PersonDetailsRoute(
Expand Down