Skip to content

[camera] Reland implementations of flip/change camera while recording #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 18 commits into from
Mar 7, 2023
Merged

[camera] Reland implementations of flip/change camera while recording #3272

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2a65549
Recreating PR from flutter/plugins
BradenBagby Feb 22, 2023
514b922
Merge branch 'main' into switch-camera-while-recording-federated2/3
BradenBagby Feb 22, 2023
3f56c85
Format fix
stuartmorgan-g Feb 23, 2023
ea06379
logs warning instead of throwing a fatal error if eglswapbuffer fails…
BradenBagby Feb 27, 2023
b8eab7e
Update packages/camera/camera_android/android/src/main/java/io/flutte…
BradenBagby Feb 27, 2023
27dfc9f
fixes test
BradenBagby Feb 28, 2023
4783ed0
Merge branch 'main' into switch-camera-while-recording-federated2/3
BradenBagby Feb 28, 2023
6e2a42f
formats
BradenBagby Feb 28, 2023
8c88b10
fixes ios formatting from merge
BradenBagby Feb 28, 2023
63dc77b
fixes test and removes device_info_plus dev dependency
BradenBagby Feb 28, 2023
d188674
Merge branch 'main' into switch-camera-while-recording-federated2/3
BradenBagby Mar 2, 2023
7390c7c
Merge branch 'main' into switch-camera-while-recording-federated2/3
BradenBagby Mar 6, 2023
d104854
Merge branch 'main' into switch-camera-while-recording-federated2/3
stuartmorgan-g Mar 7, 2023
5d691c0
Warning fix
stuartmorgan-g Mar 7, 2023
bd6812d
Format
stuartmorgan-g Mar 7, 2023
b4e54a1
removes sleep in setDescription tests
BradenBagby Mar 7, 2023
b5fb532
fixes comment
BradenBagby Mar 7, 2023
d7ace44
Format fix
stuartmorgan-g Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removes sleep in setDescription tests
  • Loading branch information
@BradenBagby
BradenBagby committed Mar 7, 2023
commit b4e54a15ddf9c4d39e4139562cf933d39bf02c41
4 changes: 0 additions & 4 deletions packages/camera/camera_android/example/integration_test/camera_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,6 @@ void main() {
await controller.prepareForVideoRecording();

await controller.startVideoRecording();
sleep(const Duration(milliseconds: 500));

// SDK < 26 will throw a platform error when trying to switch and keep the same camera
// we accept either outcome here, while the native integration tests check the outcome based on the current Android SDK
Expand All @@ -239,7 +238,6 @@ void main() {
failed = true;
}

sleep(const Duration(milliseconds: 500));

if (failed) {
// cameras did not switch
Expand All @@ -264,9 +262,7 @@ void main() {
);

await controller.initialize();
sleep(const Duration(milliseconds: 500));
await controller.setDescription(cameras[1]);
sleep(const Duration(milliseconds: 500));

expect(controller.description, cameras[1]);
});
Expand Down
4 changes: 0 additions & 4 deletions packages/camera/camera_avfoundation/example/integration_test/camera_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,7 @@ void main() {
await controller.prepareForVideoRecording();

await controller.startVideoRecording();
sleep(const Duration(milliseconds: 500));
await controller.setDescription(cameras[1]);
sleep(const Duration(milliseconds: 500));

expect(controller.description, cameras[1]);
});
Expand All @@ -236,9 +234,7 @@ void main() {
);

await controller.initialize();
sleep(const Duration(milliseconds: 500));
await controller.setDescription(cameras[1]);
sleep(const Duration(milliseconds: 500));

expect(controller.description, cameras[1]);
});
Expand Down