Skip to content

[webview_flutter] Adds onHttpError callback to NavigationDelegate to catch HTTP error status codes #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HugoOlthof wants to merge 21 commits into from
Closed

[webview_flutter] Adds onHttpError callback to NavigationDelegate to catch HTTP error status codes #3278

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
63498b0
OnPageError V4
HugoOlthof Feb 23, 2023
e1dfa71
Format all changes
HugoOlthof Feb 23, 2023
3e284c3
Adds changelogs
HugoOlthof Feb 23, 2023
5aec00b
Adds dependency overrides
HugoOlthof Feb 23, 2023
6dcd438
Fixes method not found error
HugoOlthof Feb 24, 2023
febaf9b
Updates android_webview_controller_test mock & updates changelogs and…
HugoOlthof Feb 24, 2023
4daf174
Uses mocks generated with latest stable Flutter version
HugoOlthof Feb 25, 2023
832042d
Removes unnecessary changes
HugoOlthof Feb 25, 2023
0f7c04e
Adds new line to pubspec's
HugoOlthof Feb 25, 2023
3167bd7
Fixes iOS issue where onPageError gets called for status codes < 400
HugoOlthof Feb 28, 2023
0890c1e
Introduces HttpResponseError object
HugoOlthof Mar 7, 2023
2f93d5f
Adds generated files
HugoOlthof Mar 7, 2023
92a3b65
Fixes build errors
HugoOlthof Mar 8, 2023
daa484e
Fixes changelogs
HugoOlthof Mar 8, 2023
4706214
Adds integration tests
HugoOlthof Mar 30, 2023
74e4f96
Fixes build
HugoOlthof Mar 30, 2023
2ba480c
Formats the Dart files again
HugoOlthof Apr 5, 2023
79e234d
Fixes feedback
HugoOlthof Apr 5, 2023
68d3922
Removes dependency overrides for webview_flutter_platform_interface
HugoOlthof Apr 12, 2023
6d625c1
Fixes build errors
HugoOlthof Apr 12, 2023
6d5e060
Fixes Android build errors
HugoOlthof Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes feedback
  • Loading branch information
@HugoOlthof
HugoOlthof committed Apr 12, 2023
commit 79e234d4b6ee25ade12bd98b8bd5a55d92d90a02
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter_wkwebview/lib/src/foundation/foundation.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ class NSHttpUrlResponse {
required this.statusCode,
});

/// The URL being requested.
/// The response’s HTTP status code.
final int statusCode;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter_wkwebview/lib/src/web_kit/web_kit.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ class WKNavigationAction {
final WKNavigationType navigationType;
}

/// An object that contains information about a response to a navigation request,.
/// An object that contains information about a response to a navigation request.
///
/// Wraps [WKNavigationResponse](https://developer.apple.com/documentation/webkit/wknavigationresponse?language=objc).
@immutable
Expand Down
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter_wkwebview/test/webkit_navigation_delegate_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ void main() {
expect(callbackUrl, 'https://www.google.com');
});

test('setOnPageError from decidePolicyForNavigationResponse', () {
test('setOnHttpError from decidePolicyForNavigationResponse', () {
final WebKitNavigationDelegate webKitDelgate = WebKitNavigationDelegate(
const WebKitNavigationDelegateCreationParams(
webKitProxy: WebKitProxy(
Expand Down