Skip to content

[flutter_markdown] Pass parent TextStyle down to MarkdownElementBuilder.visitElementAfter #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IchordeDionysos wants to merge 8 commits into from
Closed

[flutter_markdown] Pass parent TextStyle down to MarkdownElementBuilder.visitElementAfter #3281

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f2e66c3
Pass parent TextStyle down to MarkdownElementBuilder.visitElementAfter
IchordeDionysos Feb 23, 2023
8f6047d
Add BuildContext to the visitElementAfter method
IchordeDionysos Feb 24, 2023
f3770fc
Update builder.dart
IchordeDionysos Feb 24, 2023
de053eb
Make it a non-breaking change
IchordeDionysos Mar 7, 2023
22c6b16
Use underscore instead
IchordeDionysos Mar 7, 2023
1315839
Bump version & changelog
IchordeDionysos Mar 7, 2023
75adc21
Add test for visitElementAfterWithContext
IchordeDionysos Mar 7, 2023
f40060b
Merge branch 'main' into task/pass-parent-to-markdown-element-builder
IchordeDionysos Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bump version & changelog
  • Loading branch information
@IchordeDionysos
IchordeDionysos committed Mar 7, 2023
commit 1315839b71f8c852c9cb8e92d70c568904e14845
7 changes: 7 additions & 0 deletions packages/flutter_markdown/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## 0.6.15

* Introduce a new `MarkdownElementBuilder.visitElementAfterWithContext()` method passing the widget `BuildContext` and
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Introduces"

See the CHANGELOG style guide linked from the PR descirption.

the parent texts' `TextStyle`.
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text's

This should allow custom syntax implementations to get data from the current context, as well as properly style any
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog should just describe the change (the first sentence); it doesn't need to provide the motivation for it.

text, e.g. a color syntax can make parts of a headline colored, while still keeping the font size of the headline.

## 0.6.14

* Require `markdown: ^7.0.0`
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_markdown/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Markdown renderer for Flutter. Create rich text output,
formatted with simple Markdown tags.
repository: https://github.com/flutter/packages/tree/main/packages/flutter_markdown
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+flutter_markdown%22
version: 0.6.14
version: 0.6.15

environment:
sdk: ">=2.12.0 <3.0.0"
Expand Down