Skip to content

[webview_flutter_android] Updates Dart and Java InstanceManagers #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 30 commits into from
Mar 17, 2023
Merged

[webview_flutter_android] Updates Dart and Java InstanceManagers #3282

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
eaae468
add changed files
bparrishMines Feb 22, 2023
9d90d9f
some more changes
bparrishMines Feb 23, 2023
1094620
update tests
bparrishMines Feb 23, 2023
ce1634c
fix tests
bparrishMines Feb 23, 2023
3fae384
Merge branch 'main' of github.com:flutter/packages into instance_mana…
bparrishMines Feb 23, 2023
44e6f81
update instancemanager
bparrishMines Feb 23, 2023
ce6550b
ensure callback methods are passed to copy
bparrishMines Feb 23, 2023
def8956
version bump
bparrishMines Feb 23, 2023
ca9993e
update tests since objects can't be added multiple times
bparrishMines Feb 23, 2023
1408d00
Merge branch 'main' of github.com:flutter/packages into instance_mana…
bparrishMines Feb 27, 2023
1c48779
fix test
bparrishMines Feb 28, 2023
a552de9
change back to using copyable
bparrishMines Feb 28, 2023
9d58bd8
probably fix tests
bparrishMines Feb 28, 2023
2a05f7c
some reverts
bparrishMines Feb 28, 2023
73ea794
update changelog
bparrishMines Feb 28, 2023
625146d
Merge branch 'main' of github.com:flutter/packages into instance_mana…
bparrishMines Feb 28, 2023
32ff598
add a copy
bparrishMines Feb 28, 2023
b848c1f
raise minimum meta version
bparrishMines Feb 28, 2023
8efddc9
remove meta
bparrishMines Feb 28, 2023
e2b53b1
remove copy override
bparrishMines Feb 28, 2023
a9a9aa6
remove print
bparrishMines Feb 28, 2023
0ea91f7
remove unneeded changes
bparrishMines Feb 28, 2023
8141e9a
include raising of pigeon version
bparrishMines Feb 28, 2023
4a5aab1
Merge branch 'main' of github.com:flutter/packages into instance_mana…
bparrishMines Mar 6, 2023
f196771
update globalInstanceManager
bparrishMines Mar 6, 2023
7e32787
move location of asserts
bparrishMines Mar 6, 2023
9b572e2
Merge branch 'main' of github.com:flutter/packages into instance_mana…
bparrishMines Mar 9, 2023
1062ddb
lint
bparrishMines Mar 9, 2023
9605570
use a constant
bparrishMines Mar 16, 2023
d786495
Merge branch 'main' of github.com:flutter/packages into instance_mana…
bparrishMines Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@bparrishMines
bparrishMines committed Mar 9, 2023
commit 1062ddb536090b852f3684434e2a1edef39f5fa3
2 changes: 2 additions & 0 deletions packages/webview_flutter/webview_flutter_android/test/instance_manager_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ void main() {
MockTestInstanceManagerHostApi();
TestInstanceManagerHostApi.setup(mockApi);

// Calls method to clear the native InstanceManager.
// ignore: unnecessary_statements
JavaObject.globalInstanceManager;

verify(mockApi.clear());
Expand Down