Skip to content

[webview_flutter] Adds support to listen to url changes #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 20 commits into from
Apr 18, 2023
Merged

[webview_flutter] Adds support to listen to url changes #3313

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
dbc0e36
platform interface
bparrishMines Feb 24, 2023
14860c3
android
bparrishMines Feb 26, 2023
9bf1f7f
ios
bparrishMines Feb 27, 2023
9579d25
app facing
bparrishMines Feb 27, 2023
88766ab
Merge branch 'main' of github.com:flutter/packages into url_change_tres
bparrishMines Feb 27, 2023
e0dbc46
Merge branch 'main' of github.com:flutter/packages into url_change_tres
bparrishMines Feb 28, 2023
be6f453
fix unused parameter
bparrishMines Feb 28, 2023
9904b49
add history test and some fixes
bparrishMines Feb 28, 2023
d3ba003
undo slight mock changes
bparrishMines Feb 28, 2023
c4a9a73
Merge branch 'main' of github.com:flutter/packages into url_change_tres
bparrishMines Apr 6, 2023
b493548
remove dep overrides
bparrishMines Apr 6, 2023
08d1c2c
create webview on android
bparrishMines Apr 6, 2023
3946118
add android and wkwebview deps back
bparrishMines Apr 6, 2023
3723132
Merge branch 'main' of github.com:flutter/packages into url_change_tres
bparrishMines Apr 13, 2023
b33679b
undo changes
bparrishMines Apr 13, 2023
571bce4
docs fix
bparrishMines Apr 13, 2023
ca49681
version bumps
bparrishMines Apr 13, 2023
4517615
remove overrides
bparrishMines Apr 13, 2023
516cec3
change template name
bparrishMines Apr 13, 2023
9079fa4
Merge branch 'main' of github.com:flutter/packages into url_change_tres
bparrishMines Apr 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
create webview on android
  • Loading branch information
@bparrishMines
bparrishMines committed Apr 6, 2023
commit 08d1c2c3cb6c49e8f984d24dacb67ea85c6b5ebd
8 changes: 4 additions & 4 deletions .../android/src/main/java/io/flutter/plugins/webviewflutter/WebViewClientFlutterApiImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,10 @@ public void doUpdateVisitedHistory(
String url,
boolean isReload,
Reply<Void> callback) {
final Long webViewIdentifier = instanceManager.getIdentifierForStrongReference(webView);
if (webViewIdentifier == null) {
throw new IllegalStateException("Could not find identifier for WebView.");
}
webViewFlutterApi.create(webView, reply -> {});

final Long webViewIdentifier =
Objects.requireNonNull(instanceManager.getIdentifierForStrongReference(webView));
doUpdateVisitedHistory(
getIdentifierForClient(webViewClient), webViewIdentifier, url, isReload, callback);
}
Expand Down