Skip to content

[image_picker_android] Improved Bitmap resize on Android #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 19 commits into from
May 10, 2023
Merged

[image_picker_android] Improved Bitmap resize on Android #3423

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3ce1780
Improved Bitmap resize on Android
beroso Mar 8, 2023
27423ec
Merge branch 'flutter:main' into 118383-improve-android-bitmap-resize
beroso Mar 8, 2023
ceb3512
Update CHANGELOG
beroso Mar 8, 2023
3ce3a65
Bump version
beroso Mar 8, 2023
f7fa319
Merge branch 'main' into 118383-improve-android-bitmap-resize
beroso Mar 9, 2023
7b4dab3
Merge branch 'main' into 118383-improve-android-bitmap-resize
beroso Mar 19, 2023
68894c6
Refactor tests
beroso Mar 19, 2023
02ccb00
Fix tests
beroso Mar 19, 2023
9a8f92c
Merge branch 'main' into 118383-improve-android-bitmap-resize
beroso Mar 20, 2023
ec95f40
Perform requested changes
beroso Mar 21, 2023
bb04c94
Rename tests
beroso Mar 21, 2023
377148d
Merge branch 'main' into 118383-improve-android-bitmap-resize
beroso Mar 22, 2023
99fa594
Merge branch 'main' into 118383-improve-android-bitmap-resize
beroso Apr 13, 2023
c5b88d7
Update CHANGELOG.md
beroso Apr 14, 2023
8dbde64
Merge branch 'main' into 118383-improve-android-bitmap-resize
beroso Apr 14, 2023
22a1374
Update version
beroso Apr 14, 2023
b032b44
Update AUTHORS
beroso Apr 14, 2023
316ba79
Apply suggested changes
beroso May 5, 2023
90557a3
Merge branch 'main' into 118383-improve-android-bitmap-resize
beroso May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename tests
  • Loading branch information
@beroso
beroso committed Mar 21, 2023
commit bb04c944951749c238a8449fb93c65d9276c993f
4 changes: 2 additions & 2 deletions ...picker_android/android/src/test/java/io/flutter/plugins/imagepicker/ImageResizerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public void onResizeImageIfNeeded_whenParentDirectoryDoesNotExists_shouldNotCras
}

@Test
public void onResizeImageIfNeeded_whenResizeIsNotNecessary_shouldOnlyQueryBitmap() {
public void onResizeImageIfNeeded_whenResizeIsNotNecessary_shouldOnlyQueryBitmapDimensions() {
try (MockedStatic<BitmapFactory> mockBitmapFactory =
mockStatic(BitmapFactory.class, Mockito.CALLS_REAL_METHODS)) {
String outputFile = resizer.resizeImageIfNeeded(imageFile.getPath(), null, null, 100);
Expand All @@ -102,7 +102,7 @@ public void onResizeImageIfNeeded_whenResizeIsNotNecessary_shouldOnlyQueryBitmap
}

@Test
public void onResizeImageIfNeeded_whenResizeIsNecessary_shouldAllocateBitmap() {
public void onResizeImageIfNeeded_whenResizeIsNecessary_shouldDecodeBitmapPixels() {
try (MockedStatic<BitmapFactory> mockBitmapFactory =
mockStatic(BitmapFactory.class, Mockito.CALLS_REAL_METHODS)) {
String outputFile = resizer.resizeImageIfNeeded(imageFile.getPath(), 50.0, 50.0, 100);
Expand Down