Skip to content

[camerax] Implement video capture for CameraX android camera re-write #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camsim99 merged 19 commits into from
May 9, 2023
Merged

[camerax] Implement video capture for CameraX android camera re-write #3467

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f876e73
remaking video capture pr to fix CLA issue
May 3, 2023
ca2a353
accepting documentation change to createTempFile
May 3, 2023
22eea7a
making video recording tests into a group, and random typo
May 3, 2023
77dfba1
Merge branch 'main' into video_capture
gmackall May 4, 2023
daf385b
Merge branch 'flutter:main' into video_capture
gmackall May 8, 2023
167f9c2
documentation changes from review comments
May 8, 2023
23ec03e
changing test name
May 8, 2023
034a508
Merge branch 'flutter:main' into video_capture
gmackall May 8, 2023
d5affdd
changing a use of RuntimeException to a FlutterError
May 8, 2023
9797067
format
May 8, 2023
c76d1a4
adding tests for error cases in stopVideoRecording
May 8, 2023
3141b02
formatting
May 8, 2023
92a51b8
Making explicit that we do nothing on pressing record twice, and addi…
May 8, 2023
5e776a5
formatting new tests
May 8, 2023
0ba0dfc
review comments around documentation and an assert
May 8, 2023
89d7936
removing use of the word 'we' per the style guide
May 8, 2023
9eecbed
removing second 'assert' that was copied over from first instance of …
May 8, 2023
f8eee31
Merge branch 'main' into video_capture
gmackall May 9, 2023
fb4770b
Merge branch 'main' into video_capture
gmackall May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'flutter:main' into video_capture
  • Loading branch information
@gmackall
gmackall authored May 8, 2023
commit 034a5086b5d3269db7d77cd932da05280d25d7e1

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.