Skip to content

[webview_flutter_android] Fix the leak in the legacy implementation #3483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
Mar 21, 2023
Merged

[webview_flutter_android] Fix the leak in the legacy implementation #3483

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0430a3
fix webview leak for legacy implementation
bparrishMines Mar 16, 2023
86d5541
woiejf
bparrishMines Mar 16, 2023
3814412
fix test
bparrishMines Mar 17, 2023
67a093f
Merge branch 'main' of github.com:flutter/packages into fix_legacy_gc
bparrishMines Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
@bparrishMines
bparrishMines committed Mar 17, 2023
commit 381441217869eeb488f5ce87b579d1d64f8f0a1c
3 changes: 3 additions & 0 deletions ...flutter/webview_flutter_android/example/integration_test/legacy/webview_flutter_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ Future<void> main() async {
android.WebChromeClient.api = WebChromeClientHostApiImpl();
android.WebViewClient.api = WebViewClientHostApiImpl();
android.DownloadListener.api = DownloadListenerHostApiImpl();

// Create a new `WebStorage` with the default InstanceManager.
android.WebStorage.instance = android.WebStorage();
},
);

Expand Down
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter_android/lib/src/legacy/webview_surface_android.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import 'webview_android_widget.dart';
/// https://github.com/flutter/flutter/wiki/Hybrid-Composition for more
/// information.
class SurfaceAndroidWebView extends AndroidWebView {
/// Constructs an [SurfaceAndroidWebView].
/// Constructs a [SurfaceAndroidWebView].
SurfaceAndroidWebView({@visibleForTesting super.instanceManager});

@override
Expand Down