Skip to content

[image_picker] Move I/O operations to a separate thread #3506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 10 commits into from
Apr 28, 2023
Merged

[image_picker] Move I/O operations to a separate thread #3506

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f1892ea
Offloads result handling to separate thread
JeroenWeener Mar 21, 2023
aeff575
Add tests
JeroenWeener Mar 21, 2023
7cfc713
Update version and changelog
JeroenWeener Mar 21, 2023
06983b4
Format files
JeroenWeener Mar 21, 2023
2cba265
Restructure onActivityResult logic
JeroenWeener Apr 3, 2023
7fa1101
Synchronize `setPendingOptionsAndResult`
JeroenWeener Apr 5, 2023
b3e32b1
Remove unused imports
JeroenWeener Apr 5, 2023
38e67c1
Synchronize thread-unsafe code
JeroenWeener Apr 12, 2023
f42d307
Format `ImagePickerDelegate.java`
JeroenWeener Apr 12, 2023
557bf02
Re-bump version
stuartmorgan-g Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Synchronize setPendingOptionsAndResult
  • Loading branch information
@JeroenWeener
JeroenWeener committed Apr 28, 2023
commit 7fa110109afdb3f769a858d61f92a11ca43236b9
5 changes: 3 additions & 2 deletions ...ker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import java.util.Map;
import java.util.UUID;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.ThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
Expand Down Expand Up @@ -191,7 +192,7 @@ public void onScanCompleted(String path, Uri uri) {
}
},
new FileUtils(),
new ThreadPoolExecutor(0, 1, 1L, TimeUnit.SECONDS, new LinkedBlockingQueue<>()));
Executors.newSingleThreadExecutor());
}

/**
Expand Down Expand Up @@ -697,7 +698,7 @@ private void handleVideoResult(String path) {
finishWithSuccess(path);
}

private boolean setPendingOptionsAndResult(
private synchronized boolean setPendingOptionsAndResult(
@Nullable ImageSelectionOptions imageOptions,
@Nullable VideoSelectionOptions videoOptions,
@NonNull Messages.Result<List<String>> result) {
Expand Down