Skip to content

[go_router_builder] Adds support for required $extra parameter #3627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 11 commits into from
Apr 11, 2023
Merged

[go_router_builder] Adds support for required $extra parameter #3627

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
950b91a
adds support for required extra
dancamdev Apr 3, 2023
a443a8b
lint fixes
dancamdev Apr 3, 2023
21cf5f6
format fixes
dancamdev Apr 3, 2023
72cdcb5
fix license
dancamdev Apr 3, 2023
08ba587
Merge branch 'main' into feature/required-extra
dancamdev Apr 3, 2023
66c70a1
Merge branch 'main' into feature/required-extra
dancamdev Apr 6, 2023
8f8acd9
fix: [feature/required-extra] fix linter and add changelog link
Michele-x98 Apr 6, 2023
40b93d6
lint fixes
dancamdev Apr 7, 2023
d4d2a2c
fixed test
dancamdev Apr 7, 2023
192bf67
re-adds analyzer fixes
dancamdev Apr 7, 2023
028ec7a
Update extra_example.g.dart
Michele-x98 Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format fixes
  • Loading branch information
@dancamdev
dancamdev committed Apr 3, 2023
commit 21cf5f6d16b7416353b2f552d33fc2cc802a2d4e
9 changes: 4 additions & 5 deletions packages/go_router_builder/example/lib/extra_example.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ class OptionalExtraRoute extends GoRouteData {
OptionalExtraScreen(extra: $extra);
}


class OptionalExtraScreen extends StatelessWidget {
const OptionalExtraScreen({super.key, this.extra});

Expand All @@ -80,7 +79,6 @@ class OptionalExtraScreen extends StatelessWidget {
}
}


@TypedGoRoute<SplashRoute>(path: '/splash')
class SplashRoute extends GoRouteData {
const SplashRoute();
Expand All @@ -89,7 +87,6 @@ class SplashRoute extends GoRouteData {
Widget build(BuildContext context, GoRouterState state) => const Splash();
}


class Splash extends StatelessWidget {
const Splash({super.key});

Expand All @@ -102,11 +99,13 @@ class Splash extends StatelessWidget {
children: [
const Placeholder(),
ElevatedButton(
onPressed: () => const RequiredExtraRoute($extra: Extra(1)).go(context),
onPressed: () =>
const RequiredExtraRoute($extra: Extra(1)).go(context),
child: const Text('Required Extra'),
),
ElevatedButton(
onPressed: () => const OptionalExtraRoute($extra: Extra(2)).go(context),
onPressed: () =>
const OptionalExtraRoute($extra: Extra(2)).go(context),
child: const Text('Optional Extra'),
),
ElevatedButton(
Expand Down
5 changes: 4 additions & 1 deletion packages/go_router_builder/lib/src/route_config.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,10 @@ GoRoute get $_routeGetterName => ${_routeDefinition()};

String get _newFromState {
final StringBuffer buffer = StringBuffer('=>');
if (_ctor.isConst && _ctorParams.isEmpty && _ctorQueryParams.isEmpty && _extraParam == null) {
if (_ctor.isConst &&
_ctorParams.isEmpty &&
_ctorQueryParams.isEmpty &&
_extraParam == null) {
buffer.writeln('const ');
}

Expand Down