Skip to content

[go_router_builder] Fixed the return value of the generated push method #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 12 commits into from
Apr 21, 2023
Merged

[go_router_builder] Fixed the return value of the generated push method #3650

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2eaec6a
- fixed return value of the push method
vlazdra Apr 5, 2023
a88a038
- updated all corresponding files so that test can pass
vlazdra Apr 7, 2023
00f21ab
- bumped the version and updated the CHANGELOG accordingly
vlazdra Apr 7, 2023
866fd07
- added new example UI for the return value
vlazdra Apr 7, 2023
b95a06e
- updated the example tests
vlazdra Apr 7, 2023
6295a66
- resolved analyzer warnings
vlazdra Apr 7, 2023
828127a
Update main.dart
Michele-x98 Apr 7, 2023
4760158
Merge pull request #1 from Michele-x98/return-value-fix
vlazdra Apr 13, 2023
5f093e5
Merge branch 'main' into return-value-fix
vlazdra Apr 13, 2023
8bce211
- resolved merge conflicts and updated the version
vlazdra Apr 13, 2023
eeb86a9
- fixed failing tests
vlazdra Apr 13, 2023
02b7edb
Updated CHANGELOG.md per PR review comments
vlazdra Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
- fixed return value of the push method
  • Loading branch information
@vlazdra
vlazdra committed Apr 5, 2023
commit 2eaec6aca3b246e10741c1215a2fe4f63671d0d0
4 changes: 2 additions & 2 deletions packages/go_router_builder/lib/src/route_config.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,8 @@ extension $_extensionName on $_className {
void go(BuildContext context) =>
context.go(location${_extraParam != null ? ', extra: $extraFieldName' : ''});

void push(BuildContext context) =>
context.push(location${_extraParam != null ? ', extra: $extraFieldName' : ''});
Future<T?> push<T>(BuildContext context) =>
context.push<T>(location${_extraParam != null ? ', extra: $extraFieldName' : ''});

void pushReplacement(BuildContext context) =>
context.pushReplacement(location${_extraParam != null ? ', extra: $extraFieldName' : ''});
Expand Down