Skip to content

[webview_flutter_android] [webview_flutter_wkwebview] Adds support for PlatformNavigationDelegate.onUrlChange #3653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 13 commits into from
Apr 12, 2023
Merged

[webview_flutter_android] [webview_flutter_wkwebview] Adds support for PlatformNavigationDelegate.onUrlChange #3653

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bb5b9b1
Take from main PR
bparrishMines Apr 6, 2023
f166c84
Merge branch 'main' of github.com:flutter/packages into url_change_pl…
bparrishMines Apr 12, 2023
6f8bea5
code improve
bparrishMines Apr 12, 2023
bf62901
dont null check
bparrishMines Apr 12, 2023
4ec1876
update pigeon impl
bparrishMines Apr 12, 2023
3436c7f
fix tests
bparrishMines Apr 12, 2023
1d445ab
remove baseline
bparrishMines Apr 12, 2023
0121a89
readd baseline
bparrishMines Apr 12, 2023
5ba95c3
Merge branch 'main' of github.com:flutter/packages into url_change_pl…
bparrishMines Apr 12, 2023
812cd8b
the baseline file
bparrishMines Apr 12, 2023
b690853
return original baseline
bparrishMines Apr 12, 2023
a248565
line
bparrishMines Apr 12, 2023
bc692bf
get lint passing
bparrishMines Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dont null check
  • Loading branch information
@bparrishMines
bparrishMines committed Apr 12, 2023
commit bf62901c843748c2deb6134218b3fcdb48071d50
18 changes: 6 additions & 12 deletions packages/webview_flutter/webview_flutter_android/lib/src/android_webview_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,20 +777,14 @@ class AndroidNavigationDelegate extends PlatformNavigationDelegate {
android_webview.WebView webView,
android_webview.WebResourceRequest request,
) {
final AndroidNavigationDelegate? delegate = weakThis.target;
if (delegate != null) {
delegate._handleNavigation(
request.url,
headers: request.requestHeaders,
isForMainFrame: request.isForMainFrame,
);
}
weakThis.target?._handleNavigation(
request.url,
headers: request.requestHeaders,
isForMainFrame: request.isForMainFrame,
);
},
urlLoading: (android_webview.WebView webView, String url) {
final AndroidNavigationDelegate? delegate = weakThis.target;
if (delegate != null) {
delegate._handleNavigation(url, isForMainFrame: true);
}
weakThis.target?._handleNavigation(url, isForMainFrame: true);
},
doUpdateVisitedHistory: (
android_webview.WebView webView,
Expand Down