Skip to content

[file_selector_web] Listens to file input cancel event. #3683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 13 commits into from
Jul 12, 2023
Merged

[file_selector_web] Listens to file input cancel event. #3683

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
de10ce6
Fix-[FileSelector][web] openFiles never returns when user presses "ca…
raju-muliyashiya Apr 11, 2023
eb833ef
version bump 0.9.0+5
raju-muliyashiya Apr 11, 2023
eeafb5c
changes as per requested
raju-muliyashiya May 10, 2023
3f9ce2e
removed print statement
raju-muliyashiya May 11, 2023
ce4bde4
conflict resolved
raju-muliyashiya May 12, 2023
c8101e6
Add note about showPicker API.
ditman Jul 12, 2023
9ebad61
openFile now returns null when no files are selected, following the API.
ditman Jul 12, 2023
7e83a4c
Test simulating a cancel event.
ditman Jul 12, 2023
1a24e81
Test return null behavior.
ditman Jul 12, 2023
41db1ab
Update CHANGELOG
ditman Jul 12, 2023
1ad6926
Add documentation to README
ditman Jul 12, 2023
fde3f95
Add TestOn chrome to not confuse tooling on this web-only package.
ditman Jul 12, 2023
5df1943
Add vm flag to pathified unit test run
stuartmorgan-g Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add note about showPicker API.
  • Loading branch information
@ditman
ditman committed Jul 12, 2023
commit c8101e6052a79a3491cc353d0df70a0546747b2a
1 change: 1 addition & 0 deletions packages/file_selector/file_selector_web/lib/src/dom_helper.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ class DomHelper {
completer.complete(<XFile>[]);
});

// TODO(dit): Reimplement this with the showPicker() API, https://github.com/flutter/flutter/issues/130365
inputElement.click();

return completer.future;
Expand Down