Skip to content

[file_selector] Add getDirectoryPaths implementation for macOS #3703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
May 1, 2023
Merged

[file_selector] Add getDirectoryPaths implementation for macOS #3703

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77ace31
[file_selector] Add getDirectoryPaths implementation for macOS
stuartmorgan-g Apr 13, 2023
9477884
Update Swift tests for Pigeon changes
stuartmorgan-g Apr 13, 2023
e1fa73c
Adopt super
stuartmorgan-g Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Swift tests for Pigeon changes
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Apr 13, 2023
commit 94778841989677dfd4348ca0e007560aecab9574
18 changes: 14 additions & 4 deletions packages/file_selector/file_selector_macos/example/macos/RunnerTests/RunnerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,8 +361,13 @@ class exampleTests: XCTestCase {
canChooseDirectories: true,
canChooseFiles: false,
baseOptions: SavePanelOptions())
plugin.displayOpenPanel(options: options) { paths in
XCTAssertEqual(paths, returnPaths)
plugin.displayOpenPanel(options: options) { result in
switch result {
case .success(let paths):
XCTAssertEqual(paths, returnPaths)
case .failure(let error):
XCTFail("\(error)")
}
called.fulfill()
}

Expand All @@ -388,8 +393,13 @@ class exampleTests: XCTestCase {
canChooseDirectories: true,
canChooseFiles: false,
baseOptions: SavePanelOptions())
plugin.displayOpenPanel(options: options) { paths in
XCTAssertEqual(paths.count, 0)
plugin.displayOpenPanel(options: options) { result in
switch result {
case .success(let paths):
XCTAssertEqual(paths.count, 0)
case .failure(let error):
XCTFail("\(error)")
}
called.fulfill()
}

Expand Down