Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Relax readme check slightly
  • Loading branch information
stuartmorgan-g committed Apr 18, 2023
commit 7f432c8785d297bde2cf2fafb6eca0866c399f16
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Platform Implementation Test Apps

These are test app for manual testing and automated integration testing
These are test apps for manual testing and automated integration testing
of this platform implementation. They are not intended to demonstrate actual
use of this package, since the intent is that plugin clients use the
app-facing package.
Expand Down
9 changes: 6 additions & 3 deletions script/tool/lib/src/readme_check_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -337,8 +337,11 @@ ${indentation * 2}Please use standard capitalizations: ${sortedListString(expect
/// Returns true if the README contains the repository-standard explanation of
/// the purpose of a federated plugin implementation's example.
bool _containsImplementationExampleExplanation(List<String> readmeLines) {
return readmeLines.contains('# Platform Implementation Test App') &&
readmeLines
.any((String line) => line.contains('This is a test app for'));
return (readmeLines.contains('# Platform Implementation Test App') &&
readmeLines.any(
(String line) => line.contains('This is a test app for'))) ||
(readmeLines.contains('# Platform Implementation Test Apps') &&
readmeLines.any(
(String line) => line.contains('These are test apps for')));
}
}