Skip to content

[video_player] foundation - reduce seek accuracy to fix seek to end bug #3784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 20 commits into from
May 11, 2023
Merged

[video_player] foundation - reduce seek accuracy to fix seek to end bug #3784

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
45fb3a5
remove seek accuracy
tarrinneal Apr 20, 2023
426c067
minimal tolerance
tarrinneal Apr 20, 2023
7d167e2
tolerance only when seeking to duration
tarrinneal Apr 20, 2023
b78ae9b
format
tarrinneal Apr 21, 2023
cc5b173
changelog and comment
tarrinneal Apr 21, 2023
aa9fbbd
tests?
tarrinneal Apr 21, 2023
041dcb3
clean up
tarrinneal Apr 24, 2023
c6861f4
format
tarrinneal Apr 24, 2023
747a421
DI
tarrinneal May 3, 2023
2e12e1a
test set up
tarrinneal May 5, 2023
d130337
move interface
tarrinneal May 5, 2023
7e8fada
Pesky *, I'm sure I'll revert this before it lands
tarrinneal May 5, 2023
b61eace
no tolerance test
tarrinneal May 8, 2023
6a586d1
Finish tests
tarrinneal May 9, 2023
c9bd628
Merge 'main' into video-player-seekToEnd-bug
tarrinneal May 9, 2023
ce41a1f
review changes
tarrinneal May 10, 2023
3ef8801
format
tarrinneal May 10, 2023
46f3c7d
Nits and stub change
tarrinneal May 11, 2023
fb9b9b8
rename plugin registrar
tarrinneal May 11, 2023
7aeb3db
format
tarrinneal May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename plugin registrar
  • Loading branch information
@tarrinneal
tarrinneal authored May 11, 2023
commit fb9b9b8a001a0e3d12a7f893c4a4d0547ea30c23
2 changes: 1 addition & 1 deletion packages/video_player/video_player_avfoundation/example/ios/RunnerTests/VideoPlayerTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ - (void)testSeekToleranceWhenNotSeekingToEnd {
- (void)testSeekToleranceWhenSeekingToEnd {
NSObject<FlutterPluginRegistry> *registry =
(NSObject<FlutterPluginRegistry> *)[[UIApplication sharedApplication] delegate];
NSObject<FlutterPluginRegistrar> *registrar = [registry registrarForPlugin:@"TestSeekTolerance"];
NSObject<FlutterPluginRegistrar> *registrar = [registry registrarForPlugin:@"TestSeekToEndTolerance"];

StubAVPlayer *stubAVPlayer = [[StubAVPlayer alloc] init];
StubFVPPlayerFactory *stubFVPPlayerFactory =
Expand Down