Skip to content

[auick_action_ios] Retries multiple times to not fail ci when there is a flake #3823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
Apr 27, 2023
Merged

[auick_action_ios] Retries multiple times to not fail ci when there is a flake #3823

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
572b158
draft
Apr 25, 2023
3080c6f
retries
Apr 25, 2023
a15dfdb
adjust wait time
Apr 26, 2023
33e6db4
comments
Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
comments
  • Loading branch information
Chris Yang committed Apr 26, 2023
commit 33e6db4c6435093e4235754d3d720ee6e6e8ee14
12 changes: 11 additions & 1 deletion packages/quick_actions/quick_actions_ios/example/ios/RunnerUITests/RunnerUITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,20 @@

import XCTest

private let elementWaitingTime: TimeInterval = 5
private let elementWaitingTime: TimeInterval = 30
// The duration in when pressing the app icon to open the
// quick action menu. This duration is undocumented by Apple.
// The duration will be adjusted with `pressDurationRetryAdjustment` if
// this duration does not result in the quick action menu opened.
private let quickActionPressDuration: TimeInterval = 1.5
// If the previous try to open quick action menu did not work,
// a new try with adjust the press time by this value.
// The adjusment could be + or - depends on the result of the previous try.
private let pressDurationRetryAdjustment: TimeInterval = 0.2
// Max number of tries to open the quick action menu if failed.
Copy link
Contributor

@hellohuanlin hellohuanlin Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a short explanation why we need to retry?

Copy link
Contributor Author

@cyanglaz cyanglaz Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

// This is to deflake a situation where the quick action menu is not present after
// the long press.
// See: https://github.com/flutter/flutter/issues/125509
private let quickActionMaxRetries: Int = 4;

class RunnerUITests: XCTestCase {
Expand Down