Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
implement java side
  • Loading branch information
bparrishMines committed Apr 27, 2023
commit c67f85ed566b6fd54a6ab0e2bcb0ee7d5408607b
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,93 @@
import android.os.Build;
import android.webkit.CookieManager;
import androidx.annotation.NonNull;
import androidx.annotation.VisibleForTesting;
import io.flutter.plugin.common.BinaryMessenger;
import io.flutter.plugins.webviewflutter.GeneratedAndroidWebView.CookieManagerHostApi;
import java.util.Objects;

/**
* Host API implementation for `CookieManager`.
*
* <p>This class may handle instantiating and adding native object instances that are attached to a
* Dart instance or handle method calls on the associated native class or an instance of the class.
*/
public class CookieManagerHostApiImpl implements CookieManagerHostApi {
// To ease adding additional methods, this value is added prematurely.
@SuppressWarnings({"unused", "FieldCanBeLocal"})
private final BinaryMessenger binaryMessenger;

private final InstanceManager instanceManager;
private final CookieManagerProxy proxy;

/** Proxy for constructors and static method of `CookieManager`. */
@VisibleForTesting
static class CookieManagerProxy {
/** Handles the Dart static method `MyClass.myStaticMethod`. */
@NonNull
public CookieManager getInstance() {
return CookieManager.getInstance();
}
}

/**
* Constructs a {@link CookieManagerHostApiImpl}.
*
* @param binaryMessenger used to communicate with Dart over asynchronous messages
* @param instanceManager maintains instances stored to communicate with attached Dart objects
*/
public CookieManagerHostApiImpl(
@NonNull BinaryMessenger binaryMessenger, @NonNull InstanceManager instanceManager) {
this(binaryMessenger, instanceManager, new CookieManagerProxy());
}

/**
* Constructs a {@link CookieManagerHostApiImpl}.
*
* @param binaryMessenger used to communicate with Dart over asynchronous messages
* @param instanceManager maintains instances stored to communicate with attached Dart objects
* @param proxy proxy for constructors and static methods of `CookieManager`
*/
public CookieManagerHostApiImpl(
@NonNull BinaryMessenger binaryMessenger,
@NonNull InstanceManager instanceManager,
@NonNull CookieManagerProxy proxy) {
this.binaryMessenger = binaryMessenger;
this.instanceManager = instanceManager;
this.proxy = proxy;
}

class CookieManagerHostApiImpl implements CookieManagerHostApi {
@Override
public void clearCookies(@NonNull GeneratedAndroidWebView.Result<Boolean> result) {
CookieManager cookieManager = CookieManager.getInstance();
public void attachInstance(@NonNull Long instanceIdentifier) {
instanceManager.addDartCreatedInstance(proxy.getInstance(), instanceIdentifier);
}

@Override
public void setCookie(@NonNull Long identifier, @NonNull String url, @NonNull String value) {
getCookieManagerInstance(identifier).setCookie(url, value);
}

@Override
public void removeAllCookies(
@NonNull Long identifier, @NonNull GeneratedAndroidWebView.Result<Boolean> result) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
cookieManager.removeAllCookies(result::success);
getCookieManagerInstance(identifier).removeAllCookies(result::success);
} else {
result.success(removeCookiesPreL(cookieManager));
result.success(removeCookiesPreL(getCookieManagerInstance(identifier)));
}
}

@Override
public void setCookie(@NonNull String url, @NonNull String value) {
CookieManager.getInstance().setCookie(url, value);
public void setAcceptThirdPartyCookies(
@NonNull Long identifier, @NonNull Long webViewIdentifier, @NonNull Boolean accept) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
getCookieManagerInstance(identifier)
.setAcceptThirdPartyCookies(
Objects.requireNonNull(instanceManager.getInstance(webViewIdentifier)), accept);
} else {
throw new UnsupportedOperationException(
"`setAcceptThirdPartyCookies` is unsupported on versions below `Build.VERSION_CODES.LOLLIPOP`.");
}
}

/**
Expand All @@ -40,4 +111,9 @@ private boolean removeCookiesPreL(CookieManager cookieManager) {
}
return hasCookies;
}

@NonNull
private CookieManager getCookieManagerInstance(@NonNull Long identifier) {
return Objects.requireNonNull(instanceManager.getInstance(identifier));
}
}
Loading