Skip to content

[camerax] Add LifecycleOwner Proxy #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 11 commits into from
Apr 29, 2023
Merged

[camerax] Add LifecycleOwner Proxy #3837

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ae4fa27
Add fix and test file
camsim99 Apr 27, 2023
a2807ce
Fix test
camsim99 Apr 28, 2023
cfc5b09
Add annotation
camsim99 Apr 28, 2023
3afd604
Add dart fix
camsim99 Apr 28, 2023
c38daf5
Add mock file
camsim99 Apr 28, 2023
f19a142
Merge remote-tracking branch 'upstream/main' into camx_lifecycleowner
camsim99 Apr 28, 2023
b89c334
Start adding test
camsim99 Apr 28, 2023
ae82048
Merge remote-tracking branch 'upstream/main' into camx_lifecycleowner
camsim99 Apr 28, 2023
4a93dbd
Add test for plugin
camsim99 Apr 28, 2023
7df2c54
Add annotations
camsim99 Apr 28, 2023
7aeecac
Add changelog entry and format
camsim99 Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add changelog entry and format
  • Loading branch information
@camsim99
camsim99 committed Apr 28, 2023
commit 7aeecac0d7b1269a93c7f194aa0e1a382215cc6d
1 change: 1 addition & 0 deletions packages/camera/camera_android_camerax/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@
* Fixes cast of CameraInfo to fix integration test failure.
* Updates internal Java InstanceManager to only stop finalization callbacks when stopped.
* Implements image streaming.
* Provides LifecycleOwner implementation for Activities that use the plugin that do not implement it themselves.
4 changes: 3 additions & 1 deletion ..._camerax/android/src/main/java/io/flutter/plugins/camerax/CameraAndroidCameraxPlugin.java
View file
Open in desktop
Copy link
Contributor

@reidbaker reidbaker Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add a test for this file to make sure the fallback works.

Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ public CameraAndroidCameraxPlugin() {}

@VisibleForTesting
public void setUp(
@NonNull BinaryMessenger binaryMessenger, @NonNull Context context, @NonNull TextureRegistry textureRegistry) {
@NonNull BinaryMessenger binaryMessenger,
@NonNull Context context,
@NonNull TextureRegistry textureRegistry) {
// Set up instance manager.
instanceManager =
InstanceManager.create(
Expand Down