Skip to content

[various] Speed up build-examples #3849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 9 commits into from
May 1, 2023
Merged

[various] Speed up build-examples #3849

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1c2d4a1
Create pluginTools config for image picker
reidbaker Apr 28, 2023
58f56bc
Create pluginTools config for every example that shrunk material icon…
reidbaker Apr 28, 2023
c92cd55
Add newlines to the end of files
reidbaker May 1, 2023
60b6e51
Merge branch 'main' into i125707-speed-up-build-examples-part-1
reidbaker May 1, 2023
0a643f0
remove plugins tools config because they fail in rfw examples
reidbaker May 1, 2023
b5ff81a
Dont delete but reset changed to plugin tools config
reidbaker May 1, 2023
db4aac5
Add .pluginToolsConfig.yaml to exempt packages for CHANGELOG
reidbaker May 1, 2023
1d2cb98
Move to example build file function
reidbaker May 1, 2023
35662e6
Merge branch 'main' into i125707-speed-up-build-examples-part-1
reidbaker May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move to example build file function
  • Loading branch information
@reidbaker
reidbaker committed May 1, 2023
commit 1d2cb9875fadd139ca4034a526fb84a5b1c42f91
3 changes: 1 addition & 2 deletions script/tool/lib/src/common/package_state_utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,6 @@ Future<bool> _isDevChange(List<String> pathComponents,
pathComponents.contains('lint-baseline.xml') ||
// Example build files are very unlikely to be interesting to clients.
_isExampleBuildFile(pathComponents) ||
// Build flags are very unlikely to be interesting to clients.
pathComponents.contains('.pluginToolsConfig.yaml') ||
// Test-only gradle depenedencies don't affect clients.
await _isGradleTestDependencyChange(pathComponents,
git: git, repoPath: repoPath);
Expand All @@ -197,6 +195,7 @@ bool _isExampleBuildFile(List<String> pathComponents) {
pathComponents.contains('build.gradle') ||
pathComponents.contains('Runner.xcodeproj') ||
pathComponents.contains('CMakeLists.txt') ||
pathComponents.contains('.pluginToolsConfig.yaml') ||
pathComponents.contains('pubspec.yaml');
}

Expand Down