Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
6125eca
Recreating image capture impl from flutter/plugins
camsim99 Feb 23, 2023
5be1371
Merge remote-tracking branch 'upstream/main' into camx_imgcap
camsim99 Feb 23, 2023
b2fce3d
Fix integration tesT
camsim99 Feb 23, 2023
ed62a9a
Merge branch 'main' into camx_imgcap
camsim99 Feb 23, 2023
2e3027b
Analyzer pt 2
camsim99 Feb 23, 2023
fbd3fe5
Merge branch 'camx_imgcap' of github.com:camsim99/packages into camx_…
camsim99 Feb 23, 2023
dfa477e
Personal cleanup
camsim99 Feb 23, 2023
a651b92
Add initialization of controller
camsim99 Feb 24, 2023
884fd6c
Merge remote-tracking branch 'upstream/main' into camx_imgcap
camsim99 Feb 24, 2023
d5f8b91
Modify some docs
camsim99 Feb 24, 2023
060b7e5
Address review
camsim99 Mar 2, 2023
ff50c70
Merge remote-tracking branch 'upstream/main' into camx_imgcap
camsim99 Mar 2, 2023
fe6f1fc
Fix analyze
camsim99 Mar 2, 2023
e2643ae
Update packages/camera/camera_android_camerax/android/src/main/java/i…
camsim99 Mar 3, 2023
b7194f7
Update packages/camera/camera_android_camerax/lib/src/image_capture.dart
camsim99 Mar 3, 2023
dadc230
Start addressing review
camsim99 Mar 6, 2023
d15e1d4
Finish addressing review
camsim99 Mar 7, 2023
6dc2b77
Fix analyze
camsim99 Mar 7, 2023
f826b62
Generate mocks on stable
camsim99 Mar 7, 2023
0f7f29a
Fix/add tests
camsim99 Mar 7, 2023
1e9739b
Add isBound dart test
camsim99 Mar 7, 2023
9ba20d0
Merge remote-tracking branch 'upstream/main' into camx_imgcap
camsim99 Mar 13, 2023
5bf6b17
Start dev
camsim99 Mar 8, 2023
5e58b2c
Add cameraClosing impl
camsim99 Mar 8, 2023
4c8c94d
Add tests
camsim99 Mar 13, 2023
6a0de08
Implement occ with camera state
camsim99 Mar 14, 2023
d3ed3e7
Reimplement with live camera state
camsim99 Mar 15, 2023
d1c684f
Start adding tests
camsim99 Mar 22, 2023
c04d8c1
Add java tests
camsim99 Mar 22, 2023
b2322d2
Formatting
camsim99 Mar 22, 2023
3545aec
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 Mar 22, 2023
e1f5bdb
Fix flutter analyze
camsim99 Mar 22, 2023
2d3409b
Fix analyze
camsim99 Mar 22, 2023
1f40f47
Review
camsim99 Mar 22, 2023
6c9b04e
Fix tests, review 2
camsim99 Mar 23, 2023
6c6cbb4
review 3
camsim99 Mar 23, 2023
a0ea3c5
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 Mar 23, 2023
06c1545
fix analyze
camsim99 Mar 23, 2023
681a117
Fix cast
camsim99 Mar 23, 2023
1143a03
generate mocks on stable
camsim99 Mar 23, 2023
d431511
Formatting
camsim99 Mar 24, 2023
ab3c085
Add missing tests
camsim99 Mar 24, 2023
631f972
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 Mar 24, 2023
70c817a
Fix analyze
camsim99 Mar 24, 2023
426b438
Bump camerax version
camsim99 Mar 27, 2023
2bc4877
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 Mar 28, 2023
0fcf7c6
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 Mar 29, 2023
6c49bd9
Formatting
camsim99 Mar 29, 2023
b9daeb1
pair programming w/maurice
camsim99 Apr 11, 2023
3345878
Fixing plugin
camsim99 Apr 12, 2023
9f6646f
Current status
camsim99 Apr 13, 2023
265eb1e
Remove print statements
camsim99 Apr 14, 2023
bfc4b5e
Add print
camsim99 Apr 14, 2023
4f3c342
remove comments
camsim99 Apr 14, 2023
e3c7a5b
Review 2
camsim99 Apr 17, 2023
f341f7f
Fixing tests
camsim99 Apr 18, 2023
0d4b021
Fix tests, format
camsim99 Apr 18, 2023
ca3bd9e
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 Apr 18, 2023
540ee98
Fix test
camsim99 Apr 18, 2023
debcd3a
Fix camera test
camsim99 Apr 18, 2023
a79ee62
Start addressing review
camsim99 Apr 25, 2023
438f592
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 May 1, 2023
c44fc06
Address review, remove cast
camsim99 May 1, 2023
83aea10
Fix java tests
camsim99 May 1, 2023
5f435e8
Fix dart tests
camsim99 May 1, 2023
581af94
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 May 1, 2023
dec3d69
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 May 1, 2023
02c039f
Merge branch 'camx_occ' into camx_occ_3
camsim99 May 1, 2023
ce463ba
Undo changes to other packages
camsim99 May 1, 2023
c525162
Undo non-camera changes
camsim99 May 1, 2023
86304c3
Add getValue
camsim99 May 2, 2023
b826c18
Fix tests
camsim99 May 2, 2023
2cebb18
Add log and formatting
camsim99 May 2, 2023
04976ec
Add period
camsim99 May 2, 2023
bca72ee
Fix android test errors
camsim99 May 2, 2023
2da0b8f
Merge remote-tracking branch 'upstream/main' into camx_occ_3
camsim99 May 2, 2023
ea78ab0
fix tests
camsim99 May 3, 2023
d0b160f
Formatting
camsim99 May 3, 2023
bc7ebee
Fix tests
camsim99 May 3, 2023
9014d3b
Add mock files
camsim99 May 3, 2023
f3d6a06
Addres test comments
camsim99 May 3, 2023
34cab98
Address rest of review
camsim99 May 3, 2023
6f701a5
Address maurice review
camsim99 May 3, 2023
a636525
Address reviews
camsim99 May 4, 2023
d5a21cb
Improve comments
camsim99 May 5, 2023
bc4ebc1
Update packages/camera/camera_android_camerax/lib/src/android_camera_…
camsim99 May 8, 2023
491ab2c
Apply patch + fix dispose
camsim99 May 8, 2023
bff96a9
Merge branch 'camx_occ_3' of github.com:camsim99/packages into camx_o…
camsim99 May 8, 2023
ad40999
Merge remote-tracking branch 'upstream/main' into camx_occ_3
camsim99 May 8, 2023
a3667dd
Merge remote-tracking branch 'upstream/main' into camx_occ_3
camsim99 May 9, 2023
c3732fe
Merge remote-tracking branch 'upstream/main' into camx_occ_3
camsim99 May 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add getValue
  • Loading branch information
camsim99 committed May 2, 2023
commit 86304c3f1edb2891e2a25cbf6d3c1686e1e0b8eb
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public Long getSensorRotationDegrees(@NonNull Long identifier) {
*/
@Override
@NonNull
public Long getLiveCameraState(@NonNull Long identifier) {
public Long getCameraState(@NonNull Long identifier) {
CameraInfo cameraInfo =
(CameraInfo) Objects.requireNonNull(instanceManager.getInstance(identifier));
LiveData<CameraState> liveCameraState = cameraInfo.getCameraState();
Expand Down Expand Up @@ -84,48 +84,10 @@ public Long getExposureState(@NonNull Long identifier) {
public Long getZoomState(@NonNull Long identifier) {
CameraInfo cameraInfo =
(CameraInfo) Objects.requireNonNull(instanceManager.getInstance(identifier));
// TODO(camsim99): Create/return LiveData<ZoomState> once https://github.com/flutter/packages/pull/3419 lands.
ZoomState zoomState = cameraInfo.getZoomState().getValue();
LiveData<ZoomState> zoomState = cameraInfo.getZoomState();

ZoomStateFlutterApiImpl zoomStateFlutterApiImpl =
new ZoomStateFlutterApiImpl(binaryMessenger, instanceManager);
zoomStateFlutterApiImpl.create(zoomState, result -> {});

return instanceManager.getIdentifierForStrongReference(zoomState);
}

/**
* Retrieves the {@link ExposureState} of the {@link CameraInfo} with the specified identifier.
*/
@Override
@NonNull
public Long getExposureState(@NonNull Long identifier) {
CameraInfo cameraInfo =
(CameraInfo) Objects.requireNonNull(instanceManager.getInstance(identifier));
ExposureState exposureState = cameraInfo.getExposureState();

ExposureStateFlutterApiImpl exposureStateFlutterApiImpl =
new ExposureStateFlutterApiImpl(binaryMessenger, instanceManager);
exposureStateFlutterApiImpl.create(exposureState, result -> {});

return instanceManager.getIdentifierForStrongReference(exposureState);
}

/**
* Retrieves the current {@link ZoomState} value of the {@link CameraInfo} with the specified
* identifier.
*/
@NonNull
@Override
public Long getZoomState(@NonNull Long identifier) {
CameraInfo cameraInfo =
(CameraInfo) Objects.requireNonNull(instanceManager.getInstance(identifier));
// TODO(camsim99): Create/return LiveData<ZoomState> once https://github.com/flutter/packages/pull/3419 lands.
ZoomState zoomState = cameraInfo.getZoomState().getValue();

ZoomStateFlutterApiImpl zoomStateFlutterApiImpl =
new ZoomStateFlutterApiImpl(binaryMessenger, instanceManager);
zoomStateFlutterApiImpl.create(zoomState, result -> {});
LiveDataFlutterApiWrapper liveDataFlutterApiWrapper = new LiveDataFlutterApiWrapper(binaryMessenger, instanceManager);
liveDataFlutterApiWrapper.create(zoomState, LiveDataSupportedType.ZOOM_STATE, reply -> {});

return instanceManager.getIdentifierForStrongReference(zoomState);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ private CameraStateType(final int index) {
}

public enum LiveDataSupportedType {
CAMERA_STATE(0);
CAMERA_STATE(0),
ZOOM_STATE(1);

final int index;

Expand Down Expand Up @@ -406,79 +407,6 @@ ArrayList<Object> toList() {
}
}

/** Generated class from Pigeon that represents data sent in messages. */
public static final class ExposureCompensationRange {
private @NonNull Long minCompensation;

public @NonNull Long getMinCompensation() {
return minCompensation;
}

public void setMinCompensation(@NonNull Long setterArg) {
if (setterArg == null) {
throw new IllegalStateException("Nonnull field \"minCompensation\" is null.");
}
this.minCompensation = setterArg;
}

private @NonNull Long maxCompensation;

public @NonNull Long getMaxCompensation() {
return maxCompensation;
}

public void setMaxCompensation(@NonNull Long setterArg) {
if (setterArg == null) {
throw new IllegalStateException("Nonnull field \"maxCompensation\" is null.");
}
this.maxCompensation = setterArg;
}

/** Constructor is non-public to enforce null safety; use Builder. */
ExposureCompensationRange() {}

public static final class Builder {

private @Nullable Long minCompensation;

public @NonNull Builder setMinCompensation(@NonNull Long setterArg) {
this.minCompensation = setterArg;
return this;
}

private @Nullable Long maxCompensation;

public @NonNull Builder setMaxCompensation(@NonNull Long setterArg) {
this.maxCompensation = setterArg;
return this;
}

public @NonNull ExposureCompensationRange build() {
ExposureCompensationRange pigeonReturn = new ExposureCompensationRange();
pigeonReturn.setMinCompensation(minCompensation);
pigeonReturn.setMaxCompensation(maxCompensation);
return pigeonReturn;
}
}

@NonNull
ArrayList<Object> toList() {
ArrayList<Object> toListResult = new ArrayList<Object>(2);
toListResult.add(minCompensation);
toListResult.add(maxCompensation);
return toListResult;
}

static @NonNull ExposureCompensationRange fromList(@NonNull ArrayList<Object> list) {
ExposureCompensationRange pigeonResult = new ExposureCompensationRange();
Object minCompensation = list.get(0);
pigeonResult.setMinCompensation((minCompensation == null) ? null : ((minCompensation instanceof Integer) ? (Integer) minCompensation : (Long) minCompensation));
Object maxCompensation = list.get(1);
pigeonResult.setMaxCompensation((maxCompensation == null) ? null : ((maxCompensation instanceof Integer) ? (Integer) maxCompensation : (Long) maxCompensation));
return pigeonResult;
}
}

public interface Result<T> {
@SuppressWarnings("UnknownNullness")
void success(T result);
Expand Down Expand Up @@ -594,7 +522,7 @@ public interface CameraInfoHostApi {
Long getSensorRotationDegrees(@NonNull Long identifier);

@NonNull
Long getLiveCameraState(@NonNull Long identifier);
Long getCameraState(@NonNull Long identifier);

@NonNull
Long getExposureState(@NonNull Long identifier);
Expand Down Expand Up @@ -635,15 +563,15 @@ static void setup(@NonNull BinaryMessenger binaryMessenger, @Nullable CameraInfo
{
BasicMessageChannel<Object> channel =
new BasicMessageChannel<>(
binaryMessenger, "dev.flutter.pigeon.CameraInfoHostApi.getLiveCameraState", getCodec());
binaryMessenger, "dev.flutter.pigeon.CameraInfoHostApi.getCameraState", getCodec());
if (api != null) {
channel.setMessageHandler(
(message, reply) -> {
ArrayList<Object> wrapped = new ArrayList<Object>();
ArrayList<Object> args = (ArrayList<Object>) message;
Number identifierArg = (Number) args.get(0);
try {
Long output = api.getLiveCameraState((identifierArg == null) ? null : identifierArg.longValue());
Long output = api.getCameraState((identifierArg == null) ? null : identifierArg.longValue());
wrapped.add(0, output);
}
catch (Throwable exception) {
Expand Down Expand Up @@ -1651,85 +1579,6 @@ public void create(@NonNull Long identifierArg, @NonNull Double minZoomRatioArg,
}
}

private static class ExposureStateFlutterApiCodec extends StandardMessageCodec {
public static final ExposureStateFlutterApiCodec INSTANCE = new ExposureStateFlutterApiCodec();

private ExposureStateFlutterApiCodec() {}

@Override
protected Object readValueOfType(byte type, @NonNull ByteBuffer buffer) {
switch (type) {
case (byte) 128:
return ExposureCompensationRange.fromList((ArrayList<Object>) readValue(buffer));
default:
return super.readValueOfType(type, buffer);
}
}

@Override
protected void writeValue(@NonNull ByteArrayOutputStream stream, Object value) {
if (value instanceof ExposureCompensationRange) {
stream.write(128);
writeValue(stream, ((ExposureCompensationRange) value).toList());
} else {
super.writeValue(stream, value);
}
}
}

/** Generated class from Pigeon that represents Flutter messages that can be called from Java. */
public static class ExposureStateFlutterApi {
private final @NonNull BinaryMessenger binaryMessenger;

public ExposureStateFlutterApi(@NonNull BinaryMessenger argBinaryMessenger) {
this.binaryMessenger = argBinaryMessenger;
}

/** Public interface for sending reply. */
@SuppressWarnings("UnknownNullness")
public interface Reply<T> {
void reply(T reply);
}
/** The codec used by ExposureStateFlutterApi. */
static @NonNull MessageCodec<Object> getCodec() {
return ExposureStateFlutterApiCodec.INSTANCE;
}
public void create(@NonNull Long identifierArg, @NonNull ExposureCompensationRange exposureCompensationRangeArg, @NonNull Double exposureCompensationStepArg, @NonNull Reply<Void> callback) {
BasicMessageChannel<Object> channel =
new BasicMessageChannel<>(
binaryMessenger, "dev.flutter.pigeon.ExposureStateFlutterApi.create", getCodec());
channel.send(
new ArrayList<Object>(Arrays.asList(identifierArg, exposureCompensationRangeArg, exposureCompensationStepArg)),
channelReply -> callback.reply(null));
}
}
/** Generated class from Pigeon that represents Flutter messages that can be called from Java. */
public static class ZoomStateFlutterApi {
private final @NonNull BinaryMessenger binaryMessenger;

public ZoomStateFlutterApi(@NonNull BinaryMessenger argBinaryMessenger) {
this.binaryMessenger = argBinaryMessenger;
}

/** Public interface for sending reply. */
@SuppressWarnings("UnknownNullness")
public interface Reply<T> {
void reply(T reply);
}
/** The codec used by ZoomStateFlutterApi. */
static @NonNull MessageCodec<Object> getCodec() {
return new StandardMessageCodec();
}
public void create(@NonNull Long identifierArg, @NonNull Double minZoomRatioArg, @NonNull Double maxZoomRatioArg, @NonNull Reply<Void> callback) {
BasicMessageChannel<Object> channel =
new BasicMessageChannel<>(
binaryMessenger, "dev.flutter.pigeon.ZoomStateFlutterApi.create", getCodec());
channel.send(
new ArrayList<Object>(Arrays.asList(identifierArg, minZoomRatioArg, maxZoomRatioArg)),
channelReply -> callback.reply(null));
}
}

private static class ImageAnalysisHostApiCodec extends StandardMessageCodec {
public static final ImageAnalysisHostApiCodec INSTANCE = new ImageAnalysisHostApiCodec();

Expand Down Expand Up @@ -1973,16 +1822,46 @@ public void create(@NonNull Long identifierArg, @NonNull Long codeArg, @NonNull
channelReply -> callback.reply(null));
}
}

private static class LiveDataHostApiCodec extends StandardMessageCodec {
public static final LiveDataHostApiCodec INSTANCE = new LiveDataHostApiCodec();

private LiveDataHostApiCodec() {}

@Override
protected Object readValueOfType(byte type, @NonNull ByteBuffer buffer) {
switch (type) {
case (byte) 128:
return LiveDataSupportedTypeData.fromList((ArrayList<Object>) readValue(buffer));
default:
return super.readValueOfType(type, buffer);
}
}

@Override
protected void writeValue(@NonNull ByteArrayOutputStream stream, Object value) {
if (value instanceof LiveDataSupportedTypeData) {
stream.write(128);
writeValue(stream, ((LiveDataSupportedTypeData) value).toList());
} else {
super.writeValue(stream, value);
}
}
}

/** Generated interface from Pigeon that represents a handler of messages from Flutter. */
public interface LiveDataHostApi {

void observe(@NonNull Long identifier, @NonNull Long observerIdentifier);

void removeObservers(@NonNull Long identifier);

@Nullable
Long getValue(@NonNull Long identifier, @NonNull LiveDataSupportedTypeData type);

/** The codec used by LiveDataHostApi. */
static @NonNull MessageCodec<Object> getCodec() {
return new StandardMessageCodec();
return LiveDataHostApiCodec.INSTANCE;
}
/**Sets up an instance of `LiveDataHostApi` to handle messages through the `binaryMessenger`. */
static void setup(@NonNull BinaryMessenger binaryMessenger, @Nullable LiveDataHostApi api) {
Expand Down Expand Up @@ -2025,6 +1904,31 @@ static void setup(@NonNull BinaryMessenger binaryMessenger, @Nullable LiveDataHo
api.removeObservers((identifierArg == null) ? null : identifierArg.longValue());
wrapped.add(0, null);
}
catch (Throwable exception) {
ArrayList<Object> wrappedError = wrapError(exception);
wrapped = wrappedError;
}
reply.reply(wrapped);
});
} else {
channel.setMessageHandler(null);
}
}
{
BasicMessageChannel<Object> channel =
new BasicMessageChannel<>(
binaryMessenger, "dev.flutter.pigeon.LiveDataHostApi.getValue", getCodec());
if (api != null) {
channel.setMessageHandler(
(message, reply) -> {
ArrayList<Object> wrapped = new ArrayList<Object>();
ArrayList<Object> args = (ArrayList<Object>) message;
Number identifierArg = (Number) args.get(0);
LiveDataSupportedTypeData typeArg = (LiveDataSupportedTypeData) args.get(1);
try {
Long output = api.getValue((identifierArg == null) ? null : identifierArg.longValue(), typeArg);
wrapped.add(0, output);
}
catch (Throwable exception) {
ArrayList<Object> wrappedError = wrapError(exception);
wrapped = wrappedError;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,16 @@
package io.flutter.plugins.camerax;

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.camera.core.CameraState;
import androidx.camera.core.ZoomState;
import androidx.lifecycle.LifecycleOwner;
import androidx.lifecycle.LiveData;
import io.flutter.plugin.common.BinaryMessenger;
import io.flutter.plugins.camerax.GeneratedCameraXLibrary.LiveDataHostApi;
import io.flutter.plugins.camerax.GeneratedCameraXLibrary.LiveDataSupportedType;
import io.flutter.plugins.camerax.GeneratedCameraXLibrary.LiveDataSupportedTypeData;

import java.util.Objects;

/**
Expand Down Expand Up @@ -58,6 +64,29 @@ public void removeObservers(@NonNull Long identifier) {
getLiveDataInstance(identifier).removeObservers(lifecycleOwner);
}

@Override
@Nullable
public Long getValue(@NonNull Long identifier, @NonNull LiveDataSupportedTypeData type) {
Object value = getLiveDataInstance(identifier).getValue();
if (value == null) {
return null;
}

LiveDataSupportedType valueType = type.getValue();
switch(valueType) {
case CAMERA_STATE:
CameraState cameraState = (CameraState) value;
new CameraStateFlutterApiWrapper(binaryMessenger, instanceManager).create(cameraState, CameraStateFlutterApiWrapper.getCameraStateType(cameraState.getType()), cameraState.getError(), reply -> {});
return instanceManager.getIdentifierForStrongReference(cameraState);
case ZOOM_STATE:
ZoomState zoomState = (ZoomState) value;
new ZoomStateFlutterApiImpl(binaryMessenger, instanceManager).create(zoomState, reply -> {});
return instanceManager.getIdentifierForStrongReference(zoomState);
default:
throw new IllegalArgumentException("The type of LiveData whose value was requested is not supported.");
}
}

/** Retrieves the {@link LiveData} instance that has the specified identifier. */
private LiveData<?> getLiveDataInstance(@NonNull Long identifier) {
return Objects.requireNonNull(instanceManager.getInstance(identifier));
Expand Down
Loading