Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
a35167d
README fix
stuartmorgan-g May 1, 2023
69dc81b
Direct copy of Windows
stuartmorgan-g May 1, 2023
b110acf
Remove Windows examples, add template-created macOS and Linux examples
stuartmorgan-g May 1, 2023
e311f04
Add new platform interface pieces
stuartmorgan-g May 1, 2023
1558aa2
Update Windows implementation
stuartmorgan-g May 1, 2023
9f0f245
Add macOS and Linux implementations
stuartmorgan-g May 1, 2023
e8e6c98
Add integration test config exemptions
stuartmorgan-g May 1, 2023
5d8b155
Fix some lingering references to Windows
stuartmorgan-g May 1, 2023
fd7655d
Add TODO about PHFilePicker
stuartmorgan-g May 1, 2023
e48478e
Update desktop implementation examples to use newer APIs
stuartmorgan-g May 1, 2023
047b32a
Fix macOS
stuartmorgan-g May 1, 2023
4af92e2
Add app-facing API, update examples
stuartmorgan-g May 2, 2023
1361f31
Add README notes, version bumps, and endorsement
stuartmorgan-g May 2, 2023
094b763
Adjust labels
stuartmorgan-g May 2, 2023
c384211
Add codeowners
stuartmorgan-g May 2, 2023
ba3a86b
Update OS support table in README
stuartmorgan-g May 2, 2023
3f0161a
Fix pubspec overrides
stuartmorgan-g May 2, 2023
1d99ee1
Add desktop support to app-facing example
stuartmorgan-g May 2, 2023
7a509e3
Copyright for template-generated files
stuartmorgan-g May 2, 2023
471f87d
Revert auto-changes to existing platforms
stuartmorgan-g May 2, 2023
42ac084
Sort overrides
stuartmorgan-g May 2, 2023
a2eb725
Autoformat boilerplate code
stuartmorgan-g May 2, 2023
9174b4f
Add missing version bump
stuartmorgan-g May 2, 2023
3e4b21c
Initial review comments
stuartmorgan-g May 3, 2023
0281b4c
Remove examples for ease of review
stuartmorgan-g May 3, 2023
4ada117
Reverts removing examples for ease of review
stuartmorgan-g May 3, 2023
16ab8c2
Merge branch 'main' into image-picker-macos-linux
stuartmorgan-g May 3, 2023
921e295
Merge branch 'main' into image-picker-macos-linux
stuartmorgan-g Jun 7, 2023
7b4ebf5
Address review comments
stuartmorgan-g Jun 7, 2023
d18936d
Missing awaits
stuartmorgan-g Jun 7, 2023
9296999
Merge branch 'main' into image-picker-macos-linux
stuartmorgan-g Jun 9, 2023
ff710c6
Scrub platform interface overrides
stuartmorgan-g Jun 9, 2023
c79601e
Merge branch 'main' into image-picker-macos-linux
stuartmorgan-g Jun 9, 2023
dba80d2
Remove overrides
stuartmorgan-g Jun 9, 2023
6a86c5d
Update macOS version
stuartmorgan-g Jun 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Missing awaits
  • Loading branch information
stuartmorgan-g committed Jun 7, 2023
commit d18936dfacc3622cc79b42cc6966cdc9dc571f31
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ void main() {
test(
'getImageFromSource throws StateError when source is camera with no delegate',
() async {
expectLater(plugin.getImageFromSource(source: ImageSource.camera),
await expectLater(plugin.getImageFromSource(source: ImageSource.camera),
throwsStateError);
});

Expand Down Expand Up @@ -121,7 +121,7 @@ void main() {

test('getVideo throws StateError when source is camera with no delegate',
() async {
expectLater(
await expectLater(
plugin.getVideo(source: ImageSource.camera), throwsStateError);
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ void main() {
test(
'getImageFromSource throws StateError when source is camera with no delegate',
() async {
expectLater(plugin.getImageFromSource(source: ImageSource.camera),
await expectLater(plugin.getImageFromSource(source: ImageSource.camera),
throwsStateError);
});

Expand Down Expand Up @@ -127,7 +127,7 @@ void main() {

test('getVideo throws StateError when source is camera with no delegate',
() async {
expectLater(
await expectLater(
plugin.getVideo(source: ImageSource.camera), throwsStateError);
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,16 @@ void main() {
final FakeCameraDelegatingImagePickerPlatform implementation =
FakeCameraDelegatingImagePickerPlatform();

expectLater(implementation.getImageFromSource(source: ImageSource.camera),
await expectLater(
implementation.getImageFromSource(source: ImageSource.camera),
throwsStateError);
});

test('getVideo for camera throws if delegate is not set', () async {
final FakeCameraDelegatingImagePickerPlatform implementation =
FakeCameraDelegatingImagePickerPlatform();

expectLater(implementation.getVideo(source: ImageSource.camera),
await expectLater(implementation.getVideo(source: ImageSource.camera),
throwsStateError);
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ void main() {
test(
'getImageFromSource throws StateError when source is camera with no delegate',
() async {
expectLater(plugin.getImageFromSource(source: ImageSource.camera),
await expectLater(plugin.getImageFromSource(source: ImageSource.camera),
throwsStateError);
});

Expand Down Expand Up @@ -124,7 +124,7 @@ void main() {

test('getVideo throws StateError when source is camera with no delegate',
() async {
expectLater(
await expectLater(
plugin.getVideo(source: ImageSource.camera), throwsStateError);
});
});
Expand Down