Skip to content

[pigeon][reland]enable treat warnings as errors for swift code in unit test #3901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
May 4, 2023
Merged

[pigeon][reland]enable treat warnings as errors for swift code in unit test #3901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[pigeon]enable treat warning as errors for swift code in unit test
  • Loading branch information
@hellohuanlin
hellohuanlin committed May 3, 2023
commit cdfe5f6637432a8985aa1d0449561e4883aa3095
3 changes: 3 additions & 0 deletions packages/pigeon/platform_tests/test_plugin/example/ios/Runner.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,7 @@
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
SWIFT_VERSION = 5.0;
TEST_HOST = "$(BUILT_PRODUCTS_DIR)/Runner.app/$(BUNDLE_EXECUTABLE_FOLDER_PATH)/Runner";
};
Expand All @@ -557,6 +558,7 @@
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = dev.flutter.plugins.RunnerTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
SWIFT_VERSION = 5.0;
TEST_HOST = "$(BUILT_PRODUCTS_DIR)/Runner.app/$(BUNDLE_EXECUTABLE_FOLDER_PATH)/Runner";
};
Expand All @@ -572,6 +574,7 @@
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = dev.flutter.plugins.RunnerTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_TREAT_WARNINGS_AS_ERRORS = YES;
SWIFT_VERSION = 5.0;
TEST_HOST = "$(BUILT_PRODUCTS_DIR)/Runner.app/$(BUNDLE_EXECUTABLE_FOLDER_PATH)/Runner";
};
Expand Down
2 changes: 1 addition & 1 deletion ...ages/pigeon/platform_tests/test_plugin/example/ios/RunnerTests/NullableReturnsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class NullableReturnsTests: XCTestCase {
NullableArgHostApiSetup.setUp(binaryMessenger: binaryMessenger, api: api)
XCTAssertNotNil(binaryMessenger.handlers[channel])

let inputEncoded = binaryMessenger.codec.encode([nil])
let inputEncoded = binaryMessenger.codec.encode([nil] as [Any?])

let expectation = XCTestExpectation(description: "callback")
binaryMessenger.handlers[channel]?(inputEncoded) { _ in
Expand Down