Skip to content

[camera] Fix Java lints in camerax version #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
May 17, 2023
Merged

[camera] Fix Java lints in camerax version #3966

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a55f014
[camera] Fix Java lints in camerax version
stuartmorgan-g May 11, 2023
a4f1f33
Merge branch 'main' into lint-android-camerax
stuartmorgan-g May 17, 2023
8739d3c
Update annotations to match webview
stuartmorgan-g May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update annotations to match webview
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed May 17, 2023
commit 8739d3c773566ee9a6d95c4b29bd7d785b54a605
4 changes: 2 additions & 2 deletions ...era_android_camerax/android/src/main/java/io/flutter/plugins/camerax/InstanceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public <T> T remove(long identifier) {
* `null` if the manager doesn't contain the value.
*/
@Nullable
public Long getIdentifierForStrongReference(@NonNull Object instance) {
public Long getIdentifierForStrongReference(@Nullable Object instance) {
logWarningIfFinalizationListenerHasStopped();

final Long identifier = identifiers.get(instance);
Expand Down Expand Up @@ -178,7 +178,7 @@ public <T> T getInstance(long identifier) {
* @param instance the instance whose presence in this manager is to be tested.
* @return whether this manager contains the given `instance`.
*/
public boolean containsInstance(@NonNull Object instance) {
public boolean containsInstance(@Nullable Object instance) {
logWarningIfFinalizationListenerHasStopped();
return identifiers.containsKey(instance);
}
Expand Down