Skip to content

[ci] Enforce a minimum Kotlin version in examples #3979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stuartmorgan-g merged 4 commits into from
May 15, 2023
Merged

[ci] Enforce a minimum Kotlin version in examples #3979

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31bb29e
Add tooling check
stuartmorgan-g May 13, 2023
0747f43
Fix violations
stuartmorgan-g May 13, 2023
5c86692
Analysis fix
stuartmorgan-g May 13, 2023
4123b57
Use a variable for tests
stuartmorgan-g May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Analysis fix
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed May 13, 2023
commit 5c86692769c23c9b69a115622fc26ac062a06091
2 changes: 0 additions & 2 deletions script/tool/lib/src/gradle_check_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,6 @@ gradle.projectsEvaluated {
/// least a minimum value, if it is set at all.
bool _validateKotlinVersion(
RepositoryPackage example, List<String> gradleLines) {
final RepositoryPackage enclosingPackage = example.getEnclosingPackage()!;

final RegExp kotlinVersionRegex =
RegExp(r"ext\.kotlin_version\s*=\s*'([\d.]+)'");
RegExpMatch? match;
Expand Down