Skip to content

[image_picker] Fix crash due to SecurityException #4004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
May 19, 2023
Merged

[image_picker] Fix crash due to SecurityException #4004

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81047b9
Catch `SecurityException` in `getPathFromUri()`
JeroenWeener May 15, 2023
f4e4793
Add `SecurityException` unit test
JeroenWeener May 16, 2023
44afbb4
Omit markdown for url
JeroenWeener May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add SecurityException unit test
  • Loading branch information
@JeroenWeener
JeroenWeener committed May 19, 2023
commit f4e47933e0c510aeb1a2456a94d5c7e7c861a673
23 changes: 22 additions & 1 deletion ...age_picker_android/android/src/test/java/io/flutter/plugins/imagepicker/FileUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,16 @@
package io.flutter.plugins.imagepicker;

import static java.nio.charset.StandardCharsets.UTF_8;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
import static org.robolectric.Shadows.shadowOf;

import android.content.ContentProvider;
import android.content.ContentResolver;
import android.content.ContentValues;
import android.content.Context;
import android.database.Cursor;
Expand Down Expand Up @@ -66,7 +72,22 @@ public void FileUtil_GetPathFromUri() throws IOException {

assertTrue(bytes.length > 0);
String imageStream = new String(bytes, UTF_8);
assertTrue(imageStream.equals("imageStream"));
assertEquals("imageStream", imageStream);
}

@Test
public void FileUtil_GetPathFromUri_securityException() throws IOException {
Uri uri = Uri.parse("content://dummy/dummy.png");

ContentResolver mockContentResolver = mock(ContentResolver.class);
when(mockContentResolver.openInputStream(any(Uri.class))).thenThrow(SecurityException.class);

Context mockContext = mock(Context.class);
when(mockContext.getContentResolver()).thenReturn(mockContentResolver);

String path = fileUtils.getPathFromUri(mockContext, uri);

assertNull(path);
}

@Test
Expand Down