Skip to content

[various] Remove unnecessary null checks #4060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 9 commits into from
May 22, 2023
Merged

[various] Remove unnecessary null checks #4060

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
94b9d19
Remove option
stuartmorgan-g May 22, 2023
a507487
Fix warnings
stuartmorgan-g May 22, 2023
1d35bc9
Version bumps
stuartmorgan-g May 22, 2023
3dae072
Fix tool warnings
stuartmorgan-g May 22, 2023
0d2b967
Merge branch 'main' into analysis-options-null-check
stuartmorgan-g May 22, 2023
cb65963
Fix one missed violation
stuartmorgan-g May 22, 2023
7a70ecd
Restore a modified version of a check that is supposed to throw
stuartmorgan-g May 22, 2023
1360a15
Merge remote-tracking branch 'upstream/main' into analysis-options-nu…
stuartmorgan-g May 22, 2023
96b9206
Version change for final fix
stuartmorgan-g May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix one missed violation
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed May 22, 2023
commit cb65963d039a0d9be63ca3c4214c604e0c278e06
2 changes: 1 addition & 1 deletion packages/go_router/lib/src/route.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,7 +1198,7 @@ class _RestorableRouteMatchList extends RestorableProperty<RouteMatchList> {

@override
Object? toPrimitives() {
if (value != null && value.isNotEmpty) {
if (value.isNotEmpty) {
return _matchListCodec.encodeMatchList(value);
}
return null;
Expand Down