Skip to content

[various] Fixes unawaited_futures violations #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 18 commits into from
May 24, 2023
Merged

[various] Fixes unawaited_futures violations #4067

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b329c0f
Enable by default
stuartmorgan-g May 22, 2023
f2095ff
Add the new opt-outs
stuartmorgan-g May 23, 2023
907d834
Remove metrics center
stuartmorgan-g May 23, 2023
87051f6
Fix format
stuartmorgan-g May 23, 2023
a8c7651
Fix url_launcher tests
stuartmorgan-g May 23, 2023
8e6981e
Fix camera tests
stuartmorgan-g May 23, 2023
055260b
Fix script
stuartmorgan-g May 23, 2023
d6cb450
Fix violations
stuartmorgan-g May 23, 2023
3002f3d
Better comment wording
stuartmorgan-g May 23, 2023
d747104
CHANGELOGs and versions
stuartmorgan-g May 23, 2023
1263593
Fix typo, reword again to not refer to relative time
stuartmorgan-g May 23, 2023
bed74b3
Move new rule into test dir
stuartmorgan-g May 24, 2023
1490224
Fix test hang
stuartmorgan-g May 24, 2023
e92cac8
Restore passing errors through google_sign_in init
stuartmorgan-g May 24, 2023
b0b1895
Merge remote-tracking branch 'upstream/main' into unawaited-async
stuartmorgan-g May 24, 2023
8909565
Update excerpts
stuartmorgan-g May 24, 2023
86e18bf
Ignore analysis options changes for version check
stuartmorgan-g May 24, 2023
0b8a5ec
Fix include path
stuartmorgan-g May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix camera tests
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed May 23, 2023
commit 8e6981e318d7ac469f687459dc1da6ac7cfb1e16
4 changes: 2 additions & 2 deletions packages/camera/camera/test/camera_image_stream_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ void main() {

await cameraController.initialize();

cameraController.startVideoRecording(
await cameraController.startVideoRecording(
onAvailable: (CameraImage image) => null);

expect(
Expand All @@ -192,7 +192,7 @@ void main() {

await cameraController.initialize();

cameraController.startVideoRecording();
await cameraController.startVideoRecording();

expect(mockPlatform.streamCallLog.contains('startVideoCapturing'), isTrue);
});
Expand Down
4 changes: 2 additions & 2 deletions packages/camera/camera_android/test/android_camera_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,7 +1119,7 @@ void main() {
isMethodCall('startImageStream', arguments: null),
]);

subscription.cancel();
await subscription.cancel();
});

test('Should stop streaming', () async {
Expand All @@ -1136,7 +1136,7 @@ void main() {
final StreamSubscription<CameraImageData> subscription = camera
.onStreamedFrameAvailable(cameraId)
.listen((CameraImageData imageData) {});
subscription.cancel();
await subscription.cancel();

// Assert
expect(channel.log, <Matcher>[
Expand Down
4 changes: 2 additions & 2 deletions packages/camera/camera_avfoundation/test/avfoundation_camera_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,7 +1120,7 @@ void main() {
isMethodCall('startImageStream', arguments: null),
]);

subscription.cancel();
await subscription.cancel();
});

test('Should stop streaming', () async {
Expand All @@ -1137,7 +1137,7 @@ void main() {
final StreamSubscription<CameraImageData> subscription = camera
.onStreamedFrameAvailable(cameraId)
.listen((CameraImageData imageData) {});
subscription.cancel();
await subscription.cancel();

// Assert
expect(channel.log, <Matcher>[
Expand Down
4 changes: 2 additions & 2 deletions ...ages/camera/camera_platform_interface/test/method_channel/method_channel_camera_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1085,7 +1085,7 @@ void main() {
isMethodCall('startImageStream', arguments: null),
]);

subscription.cancel();
await subscription.cancel();
});

test('Should stop streaming', () async {
Expand All @@ -1102,7 +1102,7 @@ void main() {
final StreamSubscription<CameraImageData> subscription = camera
.onStreamedFrameAvailable(cameraId)
.listen((CameraImageData imageData) {});
subscription.cancel();
await subscription.cancel();

// Assert
expect(channel.log, <Matcher>[
Expand Down