Skip to content

[pigeon]fix a crash when casting NSNull to an Array #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 16 commits into from
Jul 6, 2023
Merged

[pigeon]fix a crash when casting NSNull to an Array #4289

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b294762
[pigeon]fix a crash when casting NSNull to an Array
hellohuanlin Jun 23, 2023
d6ddc6e
Merge branch 'main' of github.com:flutter/packages into pigeon_swift_…
tarrinneal Jun 30, 2023
8da8cfb
format
tarrinneal Jun 30, 2023
1682682
Easy button
tarrinneal Jun 30, 2023
7665c10
class with collections of null
tarrinneal Jun 30, 2023
5947fcd
not there yet
tarrinneal Jun 30, 2023
ec9ce83
wrapped class int tests
tarrinneal Jul 3, 2023
0a93b38
forgot a mac
tarrinneal Jul 3, 2023
8602bb2
snakes are scary
tarrinneal Jul 3, 2023
890ef8a
Merge branch 'main' of github.com:flutter/packages into pigeon_swift_…
tarrinneal Jul 3, 2023
aa88efc
need to remove the version number from examples
tarrinneal Jul 3, 2023
9e4f288
header
tarrinneal Jul 4, 2023
246befb
core_tests_pigeontest::
tarrinneal Jul 4, 2023
7d042a0
format
tarrinneal Jul 4, 2023
a92df55
cleaner and clearer
tarrinneal Jul 6, 2023
2b9368e
gen
tarrinneal Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
class with collections of null
  • Loading branch information
@tarrinneal
tarrinneal committed Jun 30, 2023
commit 7665c10ffacb852b0ac7ea43de0c8117329d803b
28 changes: 28 additions & 0 deletions packages/pigeon/platform_tests/shared_test_plugin_code/lib/integration_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,34 @@ void runPigeonIntegrationTests(TargetGenerator targetGenerator) {
// See https://github.com/flutter/flutter/issues/118733
skip: targetGenerator == TargetGenerator.objc);

testWidgets('Classes with list of null serialize and deserialize correctly',
(WidgetTester _) async {
final HostIntegrationCoreApi api = HostIntegrationCoreApi();

final AllNullableTypes nullableListTypes =
AllNullableTypes(aNullableList: <String?>['String', null]);

final AllNullableTypes? echoNullFilledObject =
await api.echoAllNullableTypes(nullableListTypes);

expect(
echoNullFilledObject?.aNullableList, nullableListTypes.aNullableList);
});

testWidgets('Classes with map of null serialize and deserialize correctly',
(WidgetTester _) async {
final HostIntegrationCoreApi api = HostIntegrationCoreApi();

final AllNullableTypes nullableListTypes = AllNullableTypes(
aNullableMap: <String?, String?>{'String': 'string', 'null': null});

final AllNullableTypes? echoNullFilledObject =
await api.echoAllNullableTypes(nullableListTypes);

expect(
echoNullFilledObject?.aNullableMap, nullableListTypes.aNullableMap);
});

testWidgets('errors are returned correctly', (WidgetTester _) async {
final HostIntegrationCoreApi api = HostIntegrationCoreApi();

Expand Down