Skip to content

[video_player] added iOS exception on incorrect asset path #4318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
Jul 14, 2023
Merged

[video_player] added iOS exception on incorrect asset path #4318

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cf011a5
added iOS exception on incorrect asset path
zopagaduanjr Jun 26, 2023
6552088
updated changelog
zopagaduanjr Jun 28, 2023
3b1a4c2
added incorrect asset test
zopagaduanjr Jun 29, 2023
f6456f3
updated test
zopagaduanjr Jul 1, 2023
5f1564b
updated test
zopagaduanjr Jul 4, 2023
9e77817
ran format command
zopagaduanjr Jul 11, 2023
9e1c8f2
updated test
zopagaduanjr Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
added iOS exception on incorrect asset path
  • Loading branch information
@zopagaduanjr
zopagaduanjr committed Jul 13, 2023
commit cf011a517c0576d520b4d7b05e0bc22c7da85392
3 changes: 2 additions & 1 deletion packages/video_player/video_player_avfoundation/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## NEXT
## 2.4.7

* Updates minimum supported SDK version to Flutter 3.3/Dart 2.18.
* Added iOS exception on incorrect asset path

## 2.4.6

Expand Down
14 changes: 10 additions & 4 deletions packages/video_player/video_player_avfoundation/ios/Classes/FLTVideoPlayerPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,10 +620,16 @@ - (FLTTextureMessage *)create:(FLTCreateMessage *)input error:(FlutterError **)e
} else {
assetPath = [_registrar lookupKeyForAsset:input.asset];
}
player = [[FLTVideoPlayer alloc] initWithAsset:assetPath
frameUpdater:frameUpdater
playerFactory:_playerFactory];
return [self onPlayerSetup:player frameUpdater:frameUpdater];
@try {
player = [[FLTVideoPlayer alloc] initWithAsset:assetPath
frameUpdater:frameUpdater
playerFactory:_playerFactory];
return [self onPlayerSetup:player frameUpdater:frameUpdater];
}
@catch (NSException *exception) {
Copy link
Contributor

@hellohuanlin hellohuanlin Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did it crash before when the exception is thrown?

Copy link
Contributor Author

@zopagaduanjr zopagaduanjr Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for ios yes. using the code sample of flutter/flutter#118660 (comment), it should crash and look like this

Screenshot 2023-06-28 at 9 47 56 PM

*error = [FlutterError errorWithCode:@"video_player" message:exception.reason details:nil];
return nil;
}
} else if (input.uri) {
player = [[FLTVideoPlayer alloc] initWithURL:[NSURL URLWithString:input.uri]
frameUpdater:frameUpdater
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/video_player_avfoundation/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: video_player_avfoundation
description: iOS implementation of the video_player plugin.
repository: https://github.com/flutter/packages/tree/main/packages/video_player/video_player_avfoundation
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
version: 2.4.6
version: 2.4.7

environment:
sdk: ">=2.18.0 <4.0.0"
Expand Down