Skip to content

[ci] Add a web version of Dart unit tests #4352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 21 commits into from
Jul 5, 2023
Merged

[ci] Add a web version of Dart unit tests #4352

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
fc8865e
[ci] Switch Dart unit tests to LUCI
stuartmorgan-g Jun 30, 2023
f8daed8
Remove Cirrus version
stuartmorgan-g Jun 30, 2023
2254dd7
Add new target
stuartmorgan-g Jun 30, 2023
26326e4
Temporarily repurpose the main unit tests for CI run
stuartmorgan-g Jun 30, 2023
8996888
Fix flag
stuartmorgan-g Jun 30, 2023
906fb7b
Skip non-web plugins on web
stuartmorgan-g Jun 30, 2023
9960a21
Support opting out of web tests
stuartmorgan-g Jun 30, 2023
2bc0801
Opt out flutter_migrate
stuartmorgan-g Jun 30, 2023
6608914
flutter_markdown adjustments
stuartmorgan-g Jun 30, 2023
e259bef
Opt go_router_build out
stuartmorgan-g Jun 30, 2023
e7c098f
Skip one test on web
stuartmorgan-g Jun 30, 2023
05e3144
Opt out metrics center
stuartmorgan-g Jun 30, 2023
2442d54
Temporarily opt palette_generator out
stuartmorgan-g Jun 30, 2023
b53b5ac
Opt out several more packages that don't support web
stuartmorgan-g Jun 30, 2023
c591b91
Opt out of unsupported tests in standard_message_codec
stuartmorgan-g Jun 30, 2023
da4b6f0
Temporarily disable rfw
stuartmorgan-g Jun 30, 2023
d8e0141
dart_test.yaml is a test-only change
stuartmorgan-g Jun 30, 2023
4e62e47
Opt out go_router_builder example
stuartmorgan-g Jun 30, 2023
b93cb12
Remove temporary testing hack; add new targets
stuartmorgan-g Jun 30, 2023
aac156f
Restore old default behavior, add explicit vm mode
stuartmorgan-g Jun 30, 2023
7fca7eb
Switch non-web LUCI to explicit vm mode
stuartmorgan-g Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip one test on web
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Jun 30, 2023
commit e7c098fce44372d92737695280a6c1bcb8368749
4 changes: 3 additions & 1 deletion ...es/google_maps_flutter/google_maps_flutter_platform_interface/test/types/bitmap_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,9 @@ void main() {

expect((mip.toJson() as List<dynamic>)[2], 1);
expect((scaled.toJson() as List<dynamic>)[2], 3);
});
},
// TODO(stuartmorgan): Investigate timeout on web.
Copy link
Contributor

@tarrinneal tarrinneal Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need an issue?

Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on a comment from David later I think we just need to change this to inline image data. I'll do a fast-follow on this.

skip: kIsWeb);

test('name cannot be null or empty', () {
expect(() {
Expand Down