Skip to content

Fix Router Config Issues #4300 (go_router_builder/example) #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
Jul 13, 2023
Merged

Fix Router Config Issues #4300 (go_router_builder/example) #4369

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc49e48
Fix AssertionError by adding routeInformationProvider to MaterialApp.…
bisor0627 Jun 26, 2023
71de30c
Fix. Support routerConfig
bisor0627 Jun 27, 2023
d2ae45c
Add. widget test for simple_example.dart
bisor0627 Jun 27, 2023
158a6c5
Reformat. `dart format .`
bisor0627 Jun 28, 2023
763e4bd
Fix. Support routerConfig
bisor0627 Jun 28, 2023
b0a474d
Merge branch 'main' into bugfix/routerConfig
bisor0627 Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reformat. dart format .
  • Loading branch information
@bisor0627
bisor0627 committed Jul 4, 2023
commit 158a6c5e037321585338a49f8dc9437c1524f541
16 changes: 10 additions & 6 deletions packages/go_router_builder/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ class LoginRoute extends GoRouteData {
final String? fromPage;

@override
Widget build(BuildContext context, GoRouterState state) => LoginScreen(from: fromPage);
Widget build(BuildContext context, GoRouterState state) =>
LoginScreen(from: fromPage);
}

class FamilyRoute extends GoRouteData {
Expand Down Expand Up @@ -253,9 +254,11 @@ class PersonScreen extends StatelessWidget {
body: ListView(
children: <Widget>[
ListTile(
title: Text('${person.name} ${family.name} is ${person.age} years old'),
title: Text(
'${person.name} ${family.name} is ${person.age} years old'),
),
for (final MapEntry<PersonDetails, String> entry in person.details.entries)
for (final MapEntry<PersonDetails, String> entry
in person.details.entries)
ListTile(
title: Text(
'${entry.key.name} - ${entry.value}',
Expand All @@ -269,8 +272,8 @@ class PersonScreen extends StatelessWidget {
).go(context),
child: const Text('With extra...'),
),
onTap: () =>
PersonDetailsRoute(family.id, person.id, entry.key).go(context),
onTap: () => PersonDetailsRoute(family.id, person.id, entry.key)
.go(context),
)
],
),
Expand Down Expand Up @@ -303,7 +306,8 @@ class PersonDetailsPage extends StatelessWidget {
),
),
if (extra == null) const ListTile(title: Text('No extra click!')),
if (extra != null) ListTile(title: Text('Extra click count: $extra')),
if (extra != null)
ListTile(title: Text('Extra click count: $extra')),
],
),
);
Expand Down