Skip to content

[go_router_builder] Removes path_to_regexp from the dependencies #4524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 11 commits into from
Jul 21, 2023
Merged

[go_router_builder] Removes path_to_regexp from the dependencies #4524

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c9487b3
chore: Copy path_utils.dart from go_router
ValentinVignal Jul 20, 2023
0cc50db
revamp: Remove unused methods
ValentinVignal Jul 20, 2023
205da04
refactor: Simplify path utils methods to only keep what is used
ValentinVignal Jul 20, 2023
e48e2af
chore: Remove path_to_regexp dependency
ValentinVignal Jul 20, 2023
31a3785
refactor: Update the code to use path_utils
ValentinVignal Jul 20, 2023
f898d88
chore: Increase package version
ValentinVignal Jul 20, 2023
57f71a9
chore: Only update patch version
ValentinVignal Jul 20, 2023
5969d6f
ci: Remove path_to_regexp from allowed unpinned deps
ValentinVignal Jul 20, 2023
b85acdb
Merge branch 'main' into go-router-builder/remove-path-to-regexp-from…
stuartmorgan-g Jul 20, 2023
d8391de
tests: Add path_utils unit test
ValentinVignal Jul 21, 2023
79e3bb6
Merge remote-tracking branch 'upstream/main' into go-router-builder/r…
ValentinVignal Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Increase package version
  • Loading branch information
@ValentinVignal
ValentinVignal committed Jul 20, 2023
commit f898d88324b3e5f8705d9bb1138a7a06331d47b1
4 changes: 4 additions & 0 deletions packages/go_router_builder/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.3.0

* Removes `path_to_regexp` from the dependencies.

## 2.2.2

* Bumps example go_router version and migrate example code.
Expand Down
2 changes: 1 addition & 1 deletion packages/go_router_builder/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: go_router_builder
description: >-
A builder that supports generated strongly-typed route helpers for
package:go_router
version: 2.2.2
version: 2.3.0
Copy link
Contributor

@chunhtai chunhtai Jul 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't a new feature, should probably update patch version.

Copy link
Contributor Author

@ValentinVignal ValentinVignal Jul 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I did it in chore: Only update patch version

repository: https://github.com/flutter/packages/tree/main/packages/go_router_builder
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router_builder%22

Expand Down