Skip to content

[webview_flutter] Adds option to register JavaScript console callback #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mvanbeusekom wants to merge 24 commits into from
Closed

[webview_flutter] Adds option to register JavaScript console callback #4541

Changes from 3 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
5b3f013
Adds JavaScript console override on WKWebView
mvanbeusekom Jul 21, 2023
2a388de
Adds JavaScript console override on WKWebView
mvanbeusekom Jul 21, 2023
3aa11af
Fix setConsoleLogCallback unit-test
mvanbeusekom Jul 21, 2023
0b08773
Fix analyze warning
mvanbeusekom Jul 21, 2023
fe22549
Adds the JavaScript info loglevel
mvanbeusekom Jul 24, 2023
0c45243
Fix integration test and dependencies
mvanbeusekom Jul 24, 2023
94775bb
wrap onConsoleMessage
bparrishMines Jul 25, 2023
d6b0600
Adds console log callback to Android and App facing packages
mvanbeusekom Jul 27, 2023
2eee568
Fixed formatting
mvanbeusekom Jul 27, 2023
e21cd64
Adds missing license block
mvanbeusekom Jul 27, 2023
e9b0f3d
Update packages/webview_flutter/webview_flutter_wkwebview/lib/src/web…
mvanbeusekom Aug 3, 2023
42b1210
Update packages/webview_flutter/webview_flutter_wkwebview/lib/src/web…
mvanbeusekom Aug 3, 2023
2a4dc3f
Merge remote-tracking branch 'upstream/main' into feature/forward_jav…
mvanbeusekom Aug 3, 2023
dafed42
Apply PR feedback
mvanbeusekom Aug 3, 2023
9e7fed2
Merge branch 'feature/forward_javascript_console' of github.com:basef…
mvanbeusekom Aug 3, 2023
de2a099
Apply PR feedback
mvanbeusekom Aug 3, 2023
6759419
Merge branch 'main' into feature/forward_javascript_console
mvanbeusekom Aug 3, 2023
4482d9a
Map TIP to JavaScriptConsoleLevel.debug
mvanbeusekom Aug 3, 2023
0a4f984
Merge branch 'feature/forward_javascript_console' of github.com:basef…
mvanbeusekom Aug 3, 2023
9b02117
Fix formatting and analyze warning
mvanbeusekom Aug 4, 2023
94ec766
Merge branch 'main' into feature/forward_javascript_console
mvanbeusekom Aug 4, 2023
56b2a5e
Generate updates test mocks
mvanbeusekom Aug 4, 2023
07f68b2
Merge branch 'main' of https://github.com/flutter/packages into featu…
mvanbeusekom Aug 4, 2023
4910c2e
Merge branch 'feature/forward_javascript_console' of github.com:basef…
mvanbeusekom Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ class WebKitWebViewController extends PlatformWebViewController {
/// Sets a callback that notifies the host application of any log messages
/// written to the JavaScript console.
///
/// Because the iOS WKWebView doesn't provide a build in way to access the
/// Because the iOS WKWebView doesn't provide a built-in way to access the
/// console, setting this callback will inject a custom [WKUserScript] which
/// overrides the JavaScript `console.debug`, `console.error`, `console.info`,
/// `console.log` and `console.warn` methods and forwards the console message
Expand Down