Skip to content

[video_player] Add optional web options [web] #4551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 13 commits into from
Sep 7, 2023
Merged

[video_player] Add optional web options [web] #4551

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e490ed6
feat: video_player web options
defuncart Feb 22, 2023
160f0dc
feat: split controls into VideoPlayerWebOptionsControls
defuncart May 17, 2023
d24aedc
feat: Add allowPictureInPicture (controls), allowRemotePlayback
defuncart Jul 6, 2023
5da7116
chore: Update CHANGELOG
defuncart Jul 8, 2023
7d41cfe
chore: video_player_web use latest platform interface
defuncart Jul 23, 2023
7d3b099
chore: Add tests
defuncart Jul 23, 2023
ba34c45
feat: ensure setOptions is de-initialized if called twice
defuncart Jul 25, 2023
d096a67
chore: Use removeAttribute
defuncart Jul 27, 2023
445fdcd
chore: requested changes
defuncart Aug 8, 2023
9a1e7ff
chore: revert overwritten change
defuncart Aug 8, 2023
d4a12c6
Style fixes
stuartmorgan-g Sep 1, 2023
d94124d
Bump version
stuartmorgan-g Sep 1, 2023
09de3c8
Merge branch 'main' into feature/video-player/add-optional-web-option…
stuartmorgan-g Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: Add allowPictureInPicture (controls), allowRemotePlayback
  • Loading branch information
@defuncart
defuncart committed Aug 22, 2023
commit d24aedc78c69c0695464ccf75a3faf388fdf1911
8 changes: 8 additions & 0 deletions packages/video_player/video_player_web/lib/src/video_player.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,12 +211,20 @@ class VideoPlayer {
if (controlsList.isNotEmpty) {
_videoElement.setAttribute('controlsList', controlsList);
}

if (!options.controls.allowPictureInPicture) {
_videoElement.setAttribute('disablePictureInPicture', true);
}
}

if (!options.allowContextMenu) {
_onContextMenu = (html.Event event) => event.preventDefault();
_videoElement.addEventListener('contextmenu', _onContextMenu);
}

if (!options.allowRemotePlayback) {
_videoElement.setAttribute('disableRemotePlayback', true);
}
}

/// Disposes of the current [html.VideoElement].
Expand Down