Skip to content

[ci] Add LUCI version of Android FTL tests in bringup mode #4571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 11 commits into from
Jul 28, 2023
Merged

[ci] Add LUCI version of Android FTL tests in bringup mode #4571

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b54b403
Remove default service key from gcloud, and add explicit key to Cirru…
stuartmorgan-g Jul 26, 2023
49459fa
Add FTL
stuartmorgan-g Jul 26, 2023
bda7015
Disable everything else for testing
stuartmorgan-g Jul 26, 2023
c9a3c75
Add project
stuartmorgan-g Jul 26, 2023
b575876
Fix results bucket
stuartmorgan-g Jul 26, 2023
eca166b
Remove default bucket, update unit tests
stuartmorgan-g Jul 27, 2023
69667ce
Analysis fix
stuartmorgan-g Jul 27, 2023
4fade20
Another analysis fix
stuartmorgan-g Jul 27, 2023
8a5c80c
Move FTL tests to new bringup tasks
stuartmorgan-g Jul 27, 2023
cb5ea47
Merge branch 'main' into luci-ftl-initial
reidbaker Jul 28, 2023
d779d5b
Improve comment per review feedback
stuartmorgan-g Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move FTL tests to new bringup tasks
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Jul 27, 2023
commit 8a5c80c38efed0826f09b338ce5e5ca46ef484c1
64 changes: 64 additions & 0 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,70 @@ targets:
{"dependency": "android_virtual_device", "version": "33"}
]

# Device versions of Android integration tests, run via FTL.
# TODO(stuartmorgan): Revisit whether we want these once we have more data
# about emulator tests; see https://github.com/flutter/flutter/issues/131429.
Copy link
Contributor

@reidbaker reidbaker Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think we should be more specific for our future selves. "Revisit if physical device tests are redundant once we have more data about emulator tests;

Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


- name: Linux_android android_device_tests_shard_1 master
bringup: true # New target
recipe: packages/packages
timeout: 60
properties:
target_file: android_device_tests.yaml
channel: master
version_file: flutter_master.version
package_sharding: "--shardIndex 0 --shardCount 6"

- name: Linux_android android_device_tests_shard_2 master
bringup: true # New target
recipe: packages/packages
timeout: 60
properties:
target_file: android_device_tests.yaml
channel: master
version_file: flutter_master.version
package_sharding: "--shardIndex 1 --shardCount 6"

- name: Linux_android android_device_tests_shard_3 master
bringup: true # New target
recipe: packages/packages
timeout: 60
properties:
target_file: android_device_tests.yaml
channel: master
version_file: flutter_master.version
package_sharding: "--shardIndex 2 --shardCount 6"

- name: Linux_android android_device_tests_shard_4 master
bringup: true # New target
recipe: packages/packages
timeout: 60
properties:
target_file: android_device_tests.yaml
channel: master
version_file: flutter_master.version
package_sharding: "--shardIndex 3 --shardCount 6"

- name: Linux_android android_device_tests_shard_5 master
bringup: true # New target
recipe: packages/packages
timeout: 60
properties:
target_file: android_device_tests.yaml
channel: master
version_file: flutter_master.version
package_sharding: "--shardIndex 4 --shardCount 6"

- name: Linux_android android_device_tests_shard_6 master
bringup: true # New target
recipe: packages/packages
timeout: 60
properties:
target_file: android_device_tests.yaml
channel: master
version_file: flutter_master.version
package_sharding: "--shardIndex 5 --shardCount 6"

### Web tasks ###
- name: Linux_web web_build_all_packages master
recipe: packages/packages
Expand Down
17 changes: 17 additions & 0 deletions .ci/targets/android_device_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: download Dart and Android deps
script: script/tool_runner.sh
infra_step: true
args: ["fetch-deps", "--android", "--supporting-target-platforms-only"]
- name: Firebase Test Lab
script: script/tool_runner.sh
args:
- "firebase-test-lab"
- "--device"
- "model=redfin,version=30"
- "--exclude=script/configs/exclude_integration_android.yaml"
- "--project=flutter-infra-staging"
- "--results-bucket=flutter_firebase_testlab_staging"
37 changes: 14 additions & 23 deletions .ci/targets/android_platform_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,31 +6,22 @@ tasks:
script: script/tool_runner.sh
infra_step: true
args: ["fetch-deps", "--android", "--supporting-target-platforms-only"]
#- name: build examples
# script: script/tool_runner.sh
# args: ["build-examples", "--apk"]
#- name: lint
# script: script/tool_runner.sh
# args: ["lint-android"]
- name: build examples
script: script/tool_runner.sh
args: ["build-examples", "--apk"]
- name: lint
script: script/tool_runner.sh
args: ["lint-android"]
# Native unit and native integration are split into two steps to allow for
# different exclusions.
# TODO(stuartmorgan): Eliminate the native unit test exclusion, and combine
# these steps.
#- name: native unit tests
# script: script/tool_runner.sh
# args: ["native-test", "--android", "--no-integration", "--exclude=script/configs/exclude_native_unit_android.yaml"]
#- name: native integration tests
# script: script/tool_runner.sh
# args: ["native-test", "--android", "--no-unit"]
#- name: drive examples - simulator
# script: script/tool_runner.sh
# args: ["drive-examples", "--android", "--exclude=script/configs/exclude_integration_android.yaml,script/configs/exclude_integration_android_emulator.yaml"]
- name: Firebase Test Lab
- name: native unit tests
script: script/tool_runner.sh
args: ["native-test", "--android", "--no-integration", "--exclude=script/configs/exclude_native_unit_android.yaml"]
- name: native integration tests
script: script/tool_runner.sh
args: ["native-test", "--android", "--no-unit"]
- name: drive examples
script: script/tool_runner.sh
args:
- "firebase-test-lab"
- "--device"
- "model=redfin,version=30"
- "--exclude=script/configs/exclude_integration_android.yaml"
- "--project=flutter-infra-staging"
- "--results-bucket=flutter_firebase_testlab_staging"
args: ["drive-examples", "--android", "--exclude=script/configs/exclude_integration_android.yaml,script/configs/exclude_integration_android_emulator.yaml"]