Skip to content

[platform] Import the platform package #4613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 12 commits into from
Aug 16, 2023
Merged

[platform] Import the platform package #4613

auto-submit merged 12 commits into from
Aug 16, 2023

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Jul 31, 2023 •
edited
Loading

Imports the packages platform from https://github.com/google/platform.dart

  • As there is not much history in the package, this imports it as a copy instead of going through the process of actually merging the commit history of that repo into this one.
  • The only changes relative to the current source in that repo are:

Part of flutter/flutter#130915

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jul 31, 2023

@jonahwilliams @gspencergoog Could one of you add me as an uploader to the pub.dev package so that I can transfer it to the flutter.dev (or alternately, just transfer the package to the publisher on the pub.dev Admin tab)?

@jonahwilliams
Copy link
Contributor

jonahwilliams commented Jul 31, 2023

I clicked the buttom to transfer for flutter.dev, says it will take a few minutes.

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Jul 31, 2023

says it will take a few minutes.

It didn't; I've noticed it likes to underpromise and overdeliver :) Thanks!

@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Aug 16, 2023

Ping; anyone want to sign off on this? :)

jonahwilliams
jonahwilliams approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christopherfujino
christopherfujino approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry I missed this, LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 16, 2023
@auto-submit auto-submit bot merged commit 3a183b7 into flutter:main Aug 16, 2023
@stuartmorgan-g stuartmorgan-g deleted the import-platform branch August 16, 2023 17:32
@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Aug 16, 2023

Could someone with commit access to https://github.com/google/platform.dart update the README to point people to https://github.com/flutter/packages/tree/main/packages/platform and then archive the repo as read-only?

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 17, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
3a183b7 [platform] Import the platform package (flutter/packages#4613)
3ad4610
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
Roll Packages from 9bf208f to 3b602e7 (3 revisions) (#132784)
ac66bdb 
flutter/packages@9bf208f...3b602e7

2023-08-16 [email protected] Add advice on code review for this repo (flutter/packages#4698)
2023-08-16 [email protected] [platform] Import the `platform` package (flutter/packages#4613)
2023-08-16 [email protected] Roll Flutter from f0e7c51 to 2502b51 (15 revisions) (flutter/packages#4722)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Aug 28, 2023

Could someone with commit access to https://github.com/google/platform.dart update the README to point people to https://github.com/flutter/packages/tree/main/packages/platform and then archive the repo as read-only?

@tvolkert Do you have the admin list for that repo? It looks like you probably set it up initially. (If you want to just make me an admin for the repo, I can take care of turning it down.)

@tvolkert
Copy link
Contributor

tvolkert commented Aug 28, 2023

@stuartmorgan I just added you as an admin of that repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stuartmorgan-g @jonahwilliams @tvolkert @christopherfujino